Re: [PATCH v3 3/4] rockchip: bob: Enable more configs

From: Simon Glass <sjg@chromium.org>
To: Alper Nebi Yasak <alpernebiyasak@gmail.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	"Marty E . Plummer" <hanetzer@startmail.com>,
	 Christian Hewitt <christianshewitt@gmail.com>,
	Andre Przywara <andre.przywara@arm.com>,
	 Peter Robinson <pbrobinson@gmail.com>,
	Kever Yang <kever.yang@rock-chips.com>,
	 Heiko Schocher <hs@denx.de>, Johan Jonker <jbx6244@gmail.com>,
	Tim Harvey <tharvey@gateworks.com>,
	 Alexandre Vicenzi <alexandre.vicenzi@suse.com>,
	Fabio Estevam <festevam@denx.de>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	 Philipp Tomsich <philipp.tomsich@vrull.eu>,
	Artem Lapkin <email2tema@gmail.com>
Subject: Re: [PATCH v3 3/4] rockchip: bob: Enable more configs
Date: Tue, 28 Dec 2021 01:34:27 -0700	[thread overview]
Message-ID: <CAPnjgZ116EmN+JR7huYPhbQEgz9gRwQFimVF0jr6V-XEJ6kBUg@mail.gmail.com> (raw)
In-Reply-To: <20211224134347.41812-4-alpernebiyasak@gmail.com>

On Fri, 24 Dec 2021 at 06:44, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote:
>
> This patch enables some configs that should be working on the Bob board,
> based on what is observed to work on the Kevin board.
>
> The Bob board uses an Embedded DisplayPort panel compatible with the
> simple panel and Rockchip eDP drivers. Its backlight is controlled by
> the Chromium OS Embedded Controller Pulse Width Modulator. Enable these
> for the board.
>
> Also set VIDEO_ROCKCHIP_MAX_{XRES,YRES} to 1280x800, the resolution of
> its panel. This had to be done for the Kevin board, but it's untested if
> this is actually necessary for Bob.
>
> The Rockchip video driver needs to assert/deassert some resets, so also
> enable the reset controller. RESET_ROCKCHIP defaults to y for this board
> when DM_RESET=y, so it's enough to set that.
>
> The Bob board has two USB 3.0 Type-C ports and one USB 2.0 Type-A port
> on its right side. Enable the configs relevant to USB devices so these
> can be used. This is despite a known issue with RK3399 boards where USB
> de-init causes a hang, as there is a known workaround.
>
> Some other rk3399-based devices enable support for the SoC's random
> number generator in commit a475bef5340c ("configs: rk3399: enable rng on
> firefly/rock960/rockpro64"), as it can provide a KASLR seed when booting
> using UEFI. Enable it for Bob as well.
>
> The default misc_init_r() for Rockchip boards sets cpuid and ethernet
> MAC address based on e-fuse block. A previous patch extends this on Gru
> boards to set registers related to SoC IO domains as is necessary on
> these boards. Enable this function and configs for it on Bob.
>
> The microSD card slot on this board (and others based on Gru) is
> connected to a GPIO controlled regulator (ppvar-sd-card-io), which must
> be operable by U-Boot. Enable the relevant config option to allow this.
>
> Bob boards also use the Winbond W25Q64DW SPI flash chip, enable support
> for Winbond SPI flash chips in the board config so U-Boot can boot with
> this chip.
>
> Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> Changes in v3:
> - Unset configs MMC_IO_VOLTAGE, MMC_UHS_SUPPORT, MMC_HS400_SUPPORT,
>   MMC_HS400_ES_SUPPORT, MMC_SDHCI_SDMA.
> - Add tag: "Reviewed-by: Kever Yang <kever.yang@rock-chips.com>"
>
>  configs/chromebook_bob_defconfig | 22 +++++++++++++++++++++-
>  include/configs/gru.h            |  3 +++
>  2 files changed, 24 insertions(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>
Tested on bob, kevin
Tested-by: Simon Glass <sjg@chromium.org>