All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Artem Lapkin <email2tema@gmail.com>
Cc: trini@konsulko.com, narmstrong@baylibre.com, TWarren@nvidia.com,
	 andre.przywara@arm.com, u-boot@lists.denx.de,
	u-boot-amlogic@groups.io,  christianshewitt@gmail.com,
	art@khadas.com, nick@khadas.com, gouwa@khadas.com
Subject: Re: [PATCH v2] image-board: fix wrong implementation ram disk address setup from cmdline
Date: Tue, 7 Dec 2021 08:07:34 -0700	[thread overview]
Message-ID: <CAPnjgZ12VrvgSWScMnBGNFhUpwi+yVHmcDCPwaQ9tJCu5axT9A@mail.gmail.com> (raw)
In-Reply-To: <20211125030859.2896352-1-art@khadas.com>

On Wed, 24 Nov 2021 at 20:09, Artem Lapkin <email2tema@gmail.com> wrote:
>
> Problem
>
> Wrong implementation logic: ramdisk cmdline image address always ignored!
> Next block { rd_addr = hextoul(select, NULL) } unusable for raw initrd.
>
> We have unbootable raw initrd images because, select_ramdisk for raw
> initrd images ignore submited select addr and setup rd_datap value to 0
>
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
> V2 changes
> _ rebase to master
> _ from https://patchwork.ozlabs.org/project/uboot/patch/20211016051915.4157293-1-art@khadas.com/
> ---
>  boot/image-board.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Fixes: f33a2c1bd0f ("image: Remove #ifdefs from select_ramdisk()")
Reviewed-by: Simon Glass <sjg@chromium.org>

  reply	other threads:[~2021-12-07 15:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25  3:08 [PATCH v2] image-board: fix wrong implementation ram disk address setup from cmdline Artem Lapkin
2021-12-07 15:07 ` Simon Glass [this message]
2022-01-17 19:47 ` Tom Rini
2022-01-18  7:28   ` Art Nikpal
2022-01-23  3:32   ` Art Nikpal
2022-01-24  9:26     ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ12VrvgSWScMnBGNFhUpwi+yVHmcDCPwaQ9tJCu5axT9A@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=TWarren@nvidia.com \
    --cc=andre.przywara@arm.com \
    --cc=art@khadas.com \
    --cc=christianshewitt@gmail.com \
    --cc=email2tema@gmail.com \
    --cc=gouwa@khadas.com \
    --cc=narmstrong@baylibre.com \
    --cc=nick@khadas.com \
    --cc=trini@konsulko.com \
    --cc=u-boot-amlogic@groups.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.