From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90097C4167E for ; Thu, 14 Oct 2021 15:14:39 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDADD61151 for ; Thu, 14 Oct 2021 15:14:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EDADD61151 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A8A11837EF; Thu, 14 Oct 2021 17:12:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="BteYv7Y2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F3566837B7; Thu, 14 Oct 2021 17:11:23 +0200 (CEST) Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EE4BC8356F for ; Thu, 14 Oct 2021 17:11:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ot1-x336.google.com with SMTP id p6-20020a9d7446000000b0054e6bb223f3so8676856otk.3 for ; Thu, 14 Oct 2021 08:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=f4JM7MMWEQQDijTB8hRWXBBRQGtFI/B+cWQT/FJEo58=; b=BteYv7Y2zCBGcoKrZoovW5/ycrCTxdJu3ROrkzQtmBuRVAmexgA4cBsBKXJKLKGDiQ zVtiKU+3jXkczmT23Ud/uc4ZF3ZFqx95kEHtyo00DLoNjPNJe48YxpRBpcgFBJ50C6u1 SqwUqX78sEDP3kebZqxJfbOgZpbfbKF4P0ISY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=f4JM7MMWEQQDijTB8hRWXBBRQGtFI/B+cWQT/FJEo58=; b=rSSacPwB6mB8FggHbN99v5p3z8wbyxRg6b2iwTt92IFweSpoEe+n9b+5vOhFPwfaoF 2jEcpkqLjFpkV/xjSJLMpoIWjMCx3MEEkix52vYplAXWdzpJjguCDFYxp5SWao8L30fn 8fg9ghqcCc6UU4cEcH7DGDrcjHci6eUELxDu9COBMkB0PrnychjwTyqZ8wMB9zUzs/St /JBkg4EtApH8yHVian82SwlAm3j35XNkQj8vhR8OO4i6U9Mdtsvnb4IHBBb/Rb9tVAfw d+gbvXtRY14LmJJEG8Vtzn3IS6CUTaKlj4yJJviJmqpuejZnNhDTgRyMHRgqSuekbA1v JqlQ== X-Gm-Message-State: AOAM530CyAEZ46sUHqEhLj9WbNNTnd6lFm9Hv1QxaiK5qqe3ABydrd7v hsGffdNEeYqbH8hm+IjVQOvH31fXURAo4A9lOAZ6Wg== X-Google-Smtp-Source: ABdhPJz+EYVcDoYFQ25xNzADHpIo6QVrkgxuiC7p36wvHmA9teoXsH0gn2n+ALxRsDp0R3AOS+k7cCXQBvDcaVu9Y0Q= X-Received: by 2002:a9d:7b49:: with SMTP id f9mr3083818oto.11.1634224277441; Thu, 14 Oct 2021 08:11:17 -0700 (PDT) MIME-Version: 1.0 References: <20211013154557.28479-1-kabel@kernel.org> <20211013154557.28479-2-kabel@kernel.org> In-Reply-To: <20211013154557.28479-2-kabel@kernel.org> From: Simon Glass Date: Thu, 14 Oct 2021 09:11:04 -0600 Message-ID: Subject: Re: [PATCH v2 01/13] env: Fix documentation for env_get_f() To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: Tom Rini , U-Boot Mailing List , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, 13 Oct 2021 at 09:46, Marek Beh=C3=BAn wrote: > > From: Marek Beh=C3=BAn > > This function actually returns: > - the number of bytes written into @buf excluding the terminating > NULL-byte, if there was enough space in @buf > - the number of bytes written into @buf including the terminating > NULL-byte, if there wasn't enough space in @buf > - -1 if the variable is not found > > Signed-off-by: Marek Beh=C3=BAn > --- > include/env.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/env.h b/include/env.h > index d5e2bcb530..b1a4003681 100644 > --- a/include/env.h > +++ b/include/env.h > @@ -131,7 +131,10 @@ char *from_env(const char *envvar); > * support reading the value (slowly) and some will not. > * > * @varname: Variable to look up > - * @return value of variable, or NULL if not found > + * @return number of bytes written into @buf, excluding the terminating > + * NULL-byte if there was enough space in @buf, and including the > + * terminating NULL-byte if there wasn't enough space, or -1 if the > + * variable is not found > */ > int env_get_f(const char *name, char *buf, unsigned int len); > > -- > 2.32.0 > Eek. Reviewed-by: Simon Glass