All of lore.kernel.org
 help / color / mirror / Atom feed
From: sjg at google.com <sjg@google.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dm: core: Correct address cast in dev_read_addr_ptr()
Date: Fri, 17 Nov 2017 07:41:48 -0800	[thread overview]
Message-ID: <CAPnjgZ14-kq3ciZtM8-h83HMS7nARJ-RKO5nnu6vk5Fym+yfbw@mail.gmail.com> (raw)
In-Reply-To: <20170930232523.GC3503@bill-the-cat>

On Sun, Oct 01, 2017 at 12:31:21AM +0200, Dr. Philipp Tomsich wrote:
>
> > On 30 Sep 2017, at 22:32, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Sat, Sep 30, 2017 at 06:08:02PM +0200, Dr. Philipp Tomsich wrote:
> >> Simon,
> >>
> >>> On 28 Sep 2017, at 18:14, Dr. Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote:
> >>>
> >>>
> >>>> On 28 Sep 2017, at 14:35, Simon Glass <sjg@chromium.org> wrote:
> >>>>
> >>>> This currently causes a warning in sandbox and will not do the right
> >>>> thing:
> >>>>
> >>>> drivers/core/read.c: In function ‘dev_read_addr_ptr’:
> >>>> drivers/core/read.c:64:44: warning: cast to pointer from integer of
> >>>> 	different size [-Wint-to-pointer-cast]
> >>>> return (addr == FDT_ADDR_T_NONE) ? NULL : (void *)addr;
> >>>>
> >>>> Use map_sysmem() which is the correct way to convert an address to a
> >>>> pointer.
> >>>>
> >>>> Fixes: c131c8bca8 (dm: core: add dev_read_addr_ptr())
> >>>> Signed-off-by: Simon Glass <sjg@chromium.org>
> >>>
> >>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> >>
> >>
> >> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> >>
> >> I’ll pull this one in through u-boot-rockchip now, as Tom raised it as a build
> >> issue against my last pull-request.
> >
> > Well, that's for the minor existing warning.  The big problem is the
> > build failures :)
>
> I already backed Jagan’s change to mach-tegra/cache.c out (missed that
> during my review and testing) and this is already running on Travis.
>
> I understood you that I should also address those warnings related to
> the Rockchip code?  If not, I’d rather have this one go through the -dm
> tree…

The DM warning fix can come via Simon's tree, thanks!

-- 
Tom

Applied to u-boot-dm thanks!

  parent reply	other threads:[~2017-11-17 15:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-28 12:35 [U-Boot] [PATCH] dm: core: Correct address cast in dev_read_addr_ptr() Simon Glass
2017-09-28 16:14 ` Dr. Philipp Tomsich
2017-09-30 16:08   ` Dr. Philipp Tomsich
2017-09-30 20:32     ` Tom Rini
2017-09-30 22:31       ` Dr. Philipp Tomsich
2017-09-30 23:25         ` Tom Rini
2017-11-17 15:41         ` sjg at google.com [this message]
2017-09-29  9:40 ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ14-kq3ciZtM8-h83HMS7nARJ-RKO5nnu6vk5Fym+yfbw@mail.gmail.com \
    --to=sjg@google.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.