From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF9ABC433F5 for ; Thu, 4 Nov 2021 02:51:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3649B611C7 for ; Thu, 4 Nov 2021 02:51:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3649B611C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5D3F083632; Thu, 4 Nov 2021 03:51:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="I0bgi7O5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EE9DB81BC8; Thu, 4 Nov 2021 03:51:41 +0100 (CET) Received: from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com [IPv6:2607:f8b0:4864:20::a2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 06BDE83632 for ; Thu, 4 Nov 2021 03:51:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa2f.google.com with SMTP id h133so2313039vke.10 for ; Wed, 03 Nov 2021 19:51:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kSXCcogkHD6BGYz9VhYpOpO1IW6LX5wAbldaJMV+3o4=; b=I0bgi7O5oLnBK7krmLjoqvUVFgewLVP53LkB0Zd9tK0/ol8oDdBD3hT+kd6PbzAEh+ snI1Gy1NqvrIe+K6UTYfXUSR1FxrR4fiB44vwG4TyROvBxFvXI76LnX6SnrU3stQUH3U 9Fpe5M/I2BFr80bhcO+qWu8b0OmOVCErE1090= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kSXCcogkHD6BGYz9VhYpOpO1IW6LX5wAbldaJMV+3o4=; b=OIeRL50mgICVB4OC6AFATMMUdDWt6yE347FDnG1hKtb0uCIT4p+r4vm/A0j8G+cr5W zoM3GPudP/d/KVxgqGSvKlzNA6nFY0S3iVGImgTEZ8PXZRdPBE24U3SReGtKuWiuoRIR vfITS2pnCdPNrESQpkKnzF4RyQHAo34jN3ZEkb0uL3BvK7cZ1xCVpC3IzG+spuarfPyA r+eJd83Ngk+93lYLMeViEWSiQXwhur6LiZlOuKTBYZ7mbr1QKL6ExCME5+oX3rGxR+zS l5r8e//hpXt9AOaJFxHZqkj7Fy1N2eRnUi3/UR6StZFoKb6qAsqz+ff/xIjEXJDbpzeG tlCQ== X-Gm-Message-State: AOAM533kCQ1R2tGPR3hiFLoWCuhro9Vsd/KvF4asRNdHcIn8r6ImchuL 9I44yGPBr4Ku77pJtWcgCER56d964MkWJ53Cq4b4uQ== X-Google-Smtp-Source: ABdhPJwtpV4x1m6ijUfzdfdrORmZTLcBRjAiRa2E6dROkA7quwUdhQk2Ksp1RKNCteprqGSCDoVWaiA6IxjQm5l7mqw= X-Received: by 2002:a05:6122:2178:: with SMTP id j24mr4353582vkr.11.1635994296592; Wed, 03 Nov 2021 19:51:36 -0700 (PDT) MIME-Version: 1.0 References: <20211028062356.98224-1-takahiro.akashi@linaro.org> <20211028062356.98224-3-takahiro.akashi@linaro.org> <20211029045628.GA33977@laputa> In-Reply-To: From: Simon Glass Date: Wed, 3 Nov 2021 20:51:25 -0600 Message-ID: Subject: Re: [PATCH v5 02/11] tools: mkeficapsule: add firmwware image signing To: Mark Kettenis Cc: takahiro.akashi@linaro.org, xypron.glpk@gmx.de, agraf@csgraf.de, ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, masami.hiramatsu@linaro.org, u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Mark, On Tue, 2 Nov 2021 at 09:13, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Tue, 2 Nov 2021 08:56:50 -0600 > > > > Hi Takahiro, > > > > > > - can we just build the tool always? > > > > > > This is one of my questions. > > > Why do you want to do so while there are bunch of tools that are > > > not always built. > > > > Because I think all tools should be built always. It is fine if that > > happens due to CONFIG options but we should try to avoid making it > > complicated. > > Well, unless this patchset fixes things, we can't, because > mkeficapsule doesn't build on OpenBSD. I tried looking into it, but I > can't figure out how this is even supposed to compile as a host tool: > > > In file included from tools/mkeficapsule.c:8: > In file included from include/malloc.h:369: > include/linux/string.h:15:24: error: conflicting types for 'strspn' > extern __kernel_size_t strspn(const char *,const char *); > ^ > /usr/include/string.h:88:9: note: previous declaration is here > size_t strspn(const char *, const char *); My guess is that linux/string.h should not be included, or perhaps __kernel_size_t should be defined to size_t. I doubt it would take an age to figure out, with a bit of fiddling. Regards, Simon