From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C3C3C433EF for ; Mon, 18 Oct 2021 18:13:22 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E07B6128E for ; Mon, 18 Oct 2021 18:13:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6E07B6128E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ABB5082BD6; Mon, 18 Oct 2021 20:13:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="mcgn8h6F"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 652A38119C; Mon, 18 Oct 2021 20:12:40 +0200 (CEST) Received: from mail-ua1-x931.google.com (mail-ua1-x931.google.com [IPv6:2607:f8b0:4864:20::931]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 570B182DB3 for ; Mon, 18 Oct 2021 20:12:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x931.google.com with SMTP id i22so5747223ual.10 for ; Mon, 18 Oct 2021 11:12:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nyFN4l6RWMvic/yNg8SVOiMCJmEgI/lMPjyv4pLQj3E=; b=mcgn8h6F0gqM63qL+VHkSOItpmSBPV4j5qZKM3ffR307aHEB/B/TkQJyZmzlAJ36Sp aIv9cAMgx7ksTnOtQ0FzbdRUqOWWlmKKMJfXp2javI2OhYlrO1v6OyRpSjzPm1muVpmJ w9EVjkHf9xSVz6WimS/KtKXw3v3UQx2XJ4I2I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nyFN4l6RWMvic/yNg8SVOiMCJmEgI/lMPjyv4pLQj3E=; b=P1uJbwbXixyiKXlJXDLODW4GnWIb10wEXvM0kY7gllmwgVg1GbUM2MgMRCBMGg73iP 7BcaH/3fjmYe6q0lgyEUYB8GcMAIzCmHrpvbXtR/S+yqDhfEBwkaePgekD1S/Q6U02sW oEcPF3b3kWWpO4dwj1r7OEIkpwuehzl8ciCmL+SA7PjWZ3BbANAOWJgkBwWHW8J/5nXS /DbApNNyh3mtKX+4nLHBu7A68D1uztTJv9wrhQa/uSBw/q5tq18+LpVhqS9r27PJs/fm EHMZB7Ew3TofTVmTWVIaa1LZQT3+8J8lIVVCi9GQhdhTpWCN11aUvxk0pHqknTPue8rK 4luw== X-Gm-Message-State: AOAM530XcRnpEW88MEfGgXG/MkZbUee9eLhw+97yx3tPG/BgimKWnzYN Od5eCusC1O+iKUQY/AooIFK+tLvfs3SSKwBl+bwQeA== X-Google-Smtp-Source: ABdhPJzkE+FR6d1cnp/xZyRWEz92EsAP4q+xrxqutWX2WG3trG+en10hjQomtCGvGAECwrw1bH3kJx4FHF+gvBFgLaI= X-Received: by 2002:a05:6102:3577:: with SMTP id bh23mr29581784vsb.8.1634580752846; Mon, 18 Oct 2021 11:12:32 -0700 (PDT) MIME-Version: 1.0 References: <20211014182257.468649-1-sjg@chromium.org> <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3341802.1634308345@gemini.denx.de> <3496103.1634558337@gemini.denx.de> In-Reply-To: <3496103.1634558337@gemini.denx.de> From: Simon Glass Date: Mon, 18 Oct 2021 12:12:21 -0600 Message-ID: Subject: Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file To: Wolfgang Denk Cc: U-Boot Mailing List , Heinrich Schuchardt , Tom Rini , Joe Hershberger Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Wolfgang, On Mon, 18 Oct 2021 at 05:59, Wolfgang Denk wrote: > > Dear Simon, > > In message you wrote: > > > > > I really think your fixed filename proposal does not work well in > > > reality. The file name should be Kconfig configurable. See [1] > > > for details. > > > > > > [1] https://lists.denx.de/pipermail/u-boot/2021-October/462668.html > > > > Yes I saw that but I forgot to look at it. I think it makes sense - we > > do that with devicetree, for example. > > > > Is that the only thing holding you back? > > Basically yes - the only other concerns I have is about this += > construct which makes the '+' character an illegal character for > environment variable names, but only when used at the end of the > variable. This is anything but nice or consistent. Iwonder what > happens with notations like these: > > foo+=bar -> "bar" gets appended to current value of "foo" > But what for: > foo\+=bar > or > foo+ = bar > > ? Can we just ban + ? In the above, foo\+ gives an unknown escape sequence from the C preprocessor, then the whole line is ignored by the script foo+ = bar produes a variable called "foo+ " in the environment with the value " bar" so you probably don't want that. > > And please see also my comments about changing the autostart > functionality for the user. Yes I saw that and I think it is OK to change it. What do you think? > > > I haven't seen any positive comments to this series yet... > > Maybe many long-term users of U-Boot don't see the current situation > as such a big problem? I have no idea. My original motivation was the complexity of getting the env you want using #define My current motivation is to complete the CONFIG migration, now in its 8th year. Regards, Simon