From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Sun, 26 Apr 2020 13:45:41 -0600 Subject: [PATCH 6/8] x86: Fix 64-bit compile warning In-Reply-To: <20200422004507.2025-7-aiden.park@intel.com> References: <20200422004507.2025-1-aiden.park@intel.com> <20200422004507.2025-7-aiden.park@intel.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Aiden, On Tue, 21 Apr 2020 at 18:45, wrote: > > From: Aiden Park > > This is to fix pointer type cast warning in hob command. > > Signed-off-by: Aiden Park > --- > cmd/x86/hob.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/cmd/x86/hob.c b/cmd/x86/hob.c > index 3967a7ca5a..8c2c1ffc63 100644 > --- a/cmd/x86/hob.c > +++ b/cmd/x86/hob.c > @@ -36,14 +36,14 @@ static int do_hob(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > > hdr = gd->arch.hob_list; > > - printf("HOB list address: 0x%08x\n\n", (unsigned int)hdr); > + printf("HOB list address: 0x%p\n\n", hdr); That 0x should not be there as hex is assumed in U-Boot. Do we actually need a 64-bit pointer here, or will the HOB be below 4GB? I'm really not a fan of 16-character addresses in a user command. > > - printf("# | Address | Type | Len | "); > + printf("# | Address | Type | Len | "); > printf("%36s\n", "GUID"); > - printf("---|----------|-----------|------|-"); > + printf("---|------------------|-----------|------|-"); > printf("------------------------------------\n"); > while (!end_of_hob(hdr)) { > - printf("%02x | %08x | ", i, (unsigned int)hdr); > + printf("%02x | %p | ", i, hdr); > type = hdr->type; > if (type == HOB_TYPE_UNUSED) > desc = "*Unused*"; > -- > 2.20.1 > Regards, Simon