From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Mon, 20 Nov 2017 08:38:49 -0700 Subject: [U-Boot] [PATCH 04/11] tools: mkimage: Extend mkimage to also include pmufw In-Reply-To: <5b0a43e32a370ca51c5f06e165e9af63770df509.1509969762.git.michal.simek@xilinx.com> References: <3133b3b4955ec21b2869136e7c13f69cb8c2caee.1509969762.git.michal.simek@xilinx.com> <5b0a43e32a370ca51c5f06e165e9af63770df509.1509969762.git.michal.simek@xilinx.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Michal, On 6 November 2017 at 05:02, Michal Simek wrote: > This is generated command line when PMUFW_INIT_FILE is setup. > > ./tools/mkimage -T zynqmpimage -R ./"" -n > ./"board/xilinx/zynqmp/pmufw.bin" -d spl/u-boot-spl.bin spl/boot.bin > > pmufw has to be in binary format and mkimage is using dynamic > header size generation without using calloc function based on pmufw > size. Boot.bin header is filled with pmufw size and pmufw is copied to > header data section. When header is generated mkimage append > u-boot-spl.bin. Can you reword this a bit? It is a bit confusing to read. > > Signed-off-by: Michal Simek > --- > > arch/arm/cpu/armv8/zynqmp/Kconfig | 7 +++ > scripts/Makefile.spl | 3 +- > tools/zynqmpimage.c | 99 ++++++++++++++++++++++++++++++++++++++- > 3 files changed, 107 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/cpu/armv8/zynqmp/Kconfig b/arch/arm/cpu/armv8/zynqmp/Kconfig > index 4dc8b1caf79e..7e4eaf782d17 100644 > --- a/arch/arm/cpu/armv8/zynqmp/Kconfig > +++ b/arch/arm/cpu/armv8/zynqmp/Kconfig > @@ -57,6 +57,13 @@ config BOOT_INIT_FILE > Add register writes to boot.bin format (max 256 pairs). > Expect a table of register-value pairs, e.g. "0x12345678 0x4321" > > +config PMUFW_INIT_FILE > + string "PMU firmware" > + depends on SPL > + default "" > + help > + Include PMUFW to boot.bin. Help should include full details. Abbreviations should be explained. Also are you saying that this tacks something new onto u-boot.bin? Where is that happening and how is it found at run time? I'm wondering is this might be a job for binman? > + > config ZYNQMP_USB > bool "Configure ZynqMP USB" > Regards, Simon