From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06F82C433EF for ; Thu, 14 Oct 2021 18:25:38 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82418611C8 for ; Thu, 14 Oct 2021 18:25:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 82418611C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 961DD837EE; Thu, 14 Oct 2021 20:25:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Cw5k/aSh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C3760837FD; Thu, 14 Oct 2021 20:25:12 +0200 (CEST) Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A2687836E0 for ; Thu, 14 Oct 2021 20:25:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa33.google.com with SMTP id t200so3968388vkt.0 for ; Thu, 14 Oct 2021 11:25:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=lbPQ2X/ZRf4SUgtyGa8G7A5fZZEkbfCvqPB61jUUTak=; b=Cw5k/aShl5BLDo76aV8mGFMJxEjq3RKeVDcxv/qQm8guX7fWpW5+vmFNWY8GhgJJj/ OZYjiu0pQlGv5Aw2W8begJkUUGm6vmJcplbtrXlzCMokO3n+2BZ9dpXzv+5oZqCapNLG ASX8ggURknn7uQEwLhyrbzNWRagcki37LSXqI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=lbPQ2X/ZRf4SUgtyGa8G7A5fZZEkbfCvqPB61jUUTak=; b=Fx3mPq3DTbQS55gzqbMoRqvpqmZZsNe8MqeJYHWLyAJEY2AO1BEKWv3Hwt1pRU37/8 zROkFAlO1eOQcI8aIddjUh1qXQeW959lnOIIqTsesYcs4TL20Qi4sIansAAGvNxUeI3p aSYU5Fgs8kgS63JEPOjtlR8ljIT/guhHAtJPQos9BINybBczdcE/zztJDYmwZOqTcrRD jILsLp2+UoXLl9944qcLXsuxKjrUiBI1iTsSnLsQloTh7+x5dqJdD2a8RdclnUIrYCMQ 120M3JMgQLmYU2iLeF1IHImSicCSA7Stbwv8C8EIactNcRLFzzSNhzDWhmEyeicopGEr kz4g== X-Gm-Message-State: AOAM531tQFtZV83PT/6wnVjBvbAX+8rJoYszIpqBnoAFMNLPFFe4ygP2 3fgJlFzSKlnUKEPwtOIALRPhOP9gi5MHjFO2MhfdeA== X-Google-Smtp-Source: ABdhPJxNxtpBE02gsemExRPI48oCs63Fd9oNsoTKMlmBmvn3YalzmcUIIBctKGZRAvFKUsir1ydVyFKZXP+yasNBA+E= X-Received: by 2002:a1f:2408:: with SMTP id k8mr7932768vkk.11.1634235899104; Thu, 14 Oct 2021 11:24:59 -0700 (PDT) MIME-Version: 1.0 References: <20211013154557.28479-1-kabel@kernel.org> <20211013154557.28479-5-kabel@kernel.org> <20211014180615.0fe06083@dellmb> In-Reply-To: <20211014180615.0fe06083@dellmb> From: Simon Glass Date: Thu, 14 Oct 2021 12:24:48 -0600 Message-ID: Subject: Re: [PATCH v2 04/13] env: Change env_match() to static and remove from header To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: Tom Rini , U-Boot Mailing List , =?UTF-8?B?TWFyZWsgQmVow7pu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Marek, On Thu, 14 Oct 2021 at 10:06, Marek Beh=C3=BAn wrote: > > On Thu, 14 Oct 2021 09:11:08 -0600 > Simon Glass wrote: > > > Hi Marek, > > > > On Wed, 13 Oct 2021 at 09:46, Marek Beh=C3=BAn wrote= : > > > > > > From: Marek Beh=C3=BAn > > > > > > This function was used by other parts of U-Boot in the past when > > > environment was read from underlying device one character at a time. > > > > > > This is not the case anymore. > > > > > > Signed-off-by: Marek Beh=C3=BAn > > > --- > > > cmd/nvedit.c | 30 +++++++++++++++--------------- > > > include/env.h | 11 ----------- > > > 2 files changed, 15 insertions(+), 26 deletions(-) > > > > > > diff --git a/cmd/nvedit.c b/cmd/nvedit.c > > > index ddc715b4f9..742e0924af 100644 > > > --- a/cmd/nvedit.c > > > +++ b/cmd/nvedit.c > > > @@ -706,6 +706,21 @@ char *from_env(const char *envvar) > > > return ret; > > > } > > > > > > > Please can you add the function comment here? We don't want to lose > > it. > > Simon, the comment is invalid (the function does something > different from what the comment says) and the function is only used as a > helper by env_get_f(), which comes right after it. The function is > refactored and renamend in subsequent patches, and its purpose seems > obvious to me. > > Should I really leave the comment there? That's fine but it would be good to mention that in the commit message explicitly. Also you add matching_name_get_value(). Can you add a comment to that, then= ? Regards, Simon