From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH] mmc: davinci_mmc: Cleanup to use dt in U-boot and static platdata in SPL
Date: Mon, 25 May 2020 09:38:25 -0600 [thread overview]
Message-ID: <CAPnjgZ16qZP3wodMTJFK4mn5kxwa8ssF7AjQe8FdoCofkThV3w@mail.gmail.com> (raw)
In-Reply-To: <05af55c0-50d3-a84e-4b10-3a26adc1a5e5@ti.com>
Hi Faiz,
On Mon, 25 May 2020 at 09:33, Faiz Abbas <faiz_abbas@ti.com> wrote:
>
> Hi Simon,
>
> On 25/05/20 8:27 pm, Simon Glass wrote:
> > Hi Faiz,
> >
> > On Thu, 21 May 2020 at 20:02, Faiz Abbas <faiz_abbas@ti.com> wrote:
> >>
> >> Cleanup this driver to use dt in U-boot and static platdata in SPL.
> >> This requires the following steps:
> >>
> >> 1. Move all platdata assignment from probe() to ofdata_to_platdata().
> >> This function is only called in U-boot.
> >> 2. Replicate all the platdata assignment being done in
> >> ofdata_to_platdata() in the omapl138 board file. This data is used in
> >> the SPL case where SPL_OF_CONTROL is not enabled.
> >> 3. Remove SPL_OF_CONTROL and related configs from omapl138_lcdk_defconfig
> >>
> >> This cleanup effectively reverts 3ef94715cc ('mmc: davinci: fix mmc boot in SPL')
> >>
> >> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> >> ---
> >>
> >> This patch fixes things being broken by Simon's series disabling
> >> libfdt when using of-platdata:
> >> https://patchwork.ozlabs.org/project/uboot/cover/20191107155318.103300-1-sjg at chromium.org/
> >>
> >>
> >> .../mach-davinci/include/mach/sdmmc_defs.h | 7 +++
> >> board/davinci/da8xxevm/omapl138_lcdk.c | 12 ++++
> >> configs/omapl138_lcdk_defconfig | 4 --
> >> drivers/mmc/davinci_mmc.c | 63 ++++++++-----------
> >> 4 files changed, 45 insertions(+), 41 deletions(-)
> >
> > Could this use of-platdata instead?
> >
>
> We would need to implement address translation in of-platdata to do that. I prefer merging your
> fixes with this for now and leave of-platdata up for the future.
OK, yes, we can't wait for non-existent features.
There is a bit of a queue of functionality lining up for of-platdata at present.
Regards,
Simon
next prev parent reply other threads:[~2020-05-25 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 2:02 [PATCH] mmc: davinci_mmc: Cleanup to use dt in U-boot and static platdata in SPL Faiz Abbas
2020-05-25 12:03 ` Bartosz Golaszewski
2020-05-25 14:57 ` Simon Glass
2020-05-25 15:33 ` Faiz Abbas
2020-05-25 15:38 ` Simon Glass [this message]
2020-05-26 16:54 ` Simon Glass
2020-05-26 17:37 ` Faiz Abbas
2020-05-26 18:38 ` Simon Glass
2020-06-18 13:54 ` Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ16qZP3wodMTJFK4mn5kxwa8ssF7AjQe8FdoCofkThV3w@mail.gmail.com \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.