All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH 1/1] sandbox: handling out of memory
Date: Sun, 7 Jun 2020 07:45:53 -0600	[thread overview]
Message-ID: <CAPnjgZ17WV_x+HPGAURwxHy5HkTbLovYC--rGc_Oq2miGUWV5A@mail.gmail.com> (raw)
In-Reply-To: <20200604172822.13112-1-xypron.glpk@gmx.de>

Hi Heinrich,

On Thu, 4 Jun 2020 at 11:28, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> assert() only works in debug mode. So checking a successful memory
> allocation should not use assert().
>

Reviewed-by: Simon Glass <sjg@chromium.org>

What sort of environment are you using that returns NULL in this case?

Regards,
Simon


> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  arch/sandbox/cpu/state.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/sandbox/cpu/state.c b/arch/sandbox/cpu/state.c
> index 1f794123b3..34b6fff7e7 100644
> --- a/arch/sandbox/cpu/state.c
> +++ b/arch/sandbox/cpu/state.c
> @@ -378,7 +378,10 @@ int state_init(void)
>
>         state->ram_size = CONFIG_SYS_SDRAM_SIZE;
>         state->ram_buf = os_malloc(state->ram_size);
> -       assert(state->ram_buf);
> +       if (!state->ram_buf) {
> +               printf("Out of memory\n");
> +               os_exit(1);
> +       }
>
>         state_reset_for_test(state);
>         /*
> --
> 2.26.2
>

  reply	other threads:[~2020-06-07 13:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04 17:28 [PATCH 1/1] sandbox: handling out of memory Heinrich Schuchardt
2020-06-07 13:45 ` Simon Glass [this message]
2020-06-07 14:02   ` Heinrich Schuchardt
2020-06-07 16:54     ` Heinrich Schuchardt
2020-07-06  1:34     ` Simon Glass
2020-07-06  1:37     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ17WV_x+HPGAURwxHy5HkTbLovYC--rGc_Oq2miGUWV5A@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.