From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40DE3C761AF for ; Sun, 2 Apr 2023 02:42:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0B71485F2C; Sun, 2 Apr 2023 04:41:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="EUuSxadt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1AD7685EF3; Sun, 2 Apr 2023 04:41:38 +0200 (CEST) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A2A9885E80 for ; Sun, 2 Apr 2023 04:41:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ed1-x536.google.com with SMTP id t10so104401279edd.12 for ; Sat, 01 Apr 2023 19:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1680403289; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=s0zUyiZ6+1fmsDMqTehHmOVJgsaqNRppEKndAlOlw58=; b=EUuSxadtlhEbJYtqEBIYEGE9GoiOR1E8fJ4uJGrAzrEWON5AXcfVAcEMxiLfuXV1Hs idNkaA+hfjOXq7mSi44RbZVmpYxlySAkMyTgelAkdP9a/pBPqgll4RV7xMDRg3T8+42g AjhHp5LQCjNojP7EfmxoUAdXMh0LqZTWOhFGo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680403289; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s0zUyiZ6+1fmsDMqTehHmOVJgsaqNRppEKndAlOlw58=; b=Ny7UwiitW+b7qUcGhX9yeObzSz5QmoDDpbARfEfS0rr0gm0d6bMddKVqL9h0VEML6f WtBqmRmy5+M6gdfyeKySNhe74JA1LosEy62MoSIfBfNIs2hwwo9qpf3YxMklSOVB/Hqb s2xw4giKELf9OtYx6HkJHyR0WgQB6EE/kGYxJPbBRxAF9IqO7FDzdNv7DfpSzAKcNdYw A5lcHgLgq9zPsYFWpfuMoczbFiRxiA7HBVzvC2cjp6ZnVq+lPNef5IB3/7/U3Exqujsy MWDDyzLSJRP0B4wXbewRqpN4xGrTPtAHLMRAa5TEjBpIfpFy44F95i/NmAxwGSVwVT6J 5NBA== X-Gm-Message-State: AAQBX9eDnvkgXy1wrpgpElp7avqGIXJzQOovivtUNWjDUWbv9LSNAXcQ 7ZCGLoe9SeRhrtVvMYMbeliuQrL86UOnGPOo2Y3Lzw== X-Google-Smtp-Source: AKy350bfnvSbEEyfYpRpSBhIflihTAEswqf+LExCC8RKDawoFEJdHZSRI9nnn7bDhCGgIvVi0dB2DnFTS70tf2g3HKY= X-Received: by 2002:a50:f68b:0:b0:4fb:ebdd:6a03 with SMTP id d11-20020a50f68b000000b004fbebdd6a03mr16076028edn.5.1680403288978; Sat, 01 Apr 2023 19:41:28 -0700 (PDT) MIME-Version: 1.0 References: <20230328161157.219375-1-abdellatif.elkhlifi@arm.com> <20230328161157.219375-11-abdellatif.elkhlifi@arm.com> In-Reply-To: <20230328161157.219375-11-abdellatif.elkhlifi@arm.com> From: Simon Glass Date: Sun, 2 Apr 2023 14:41:17 +1200 Message-ID: Subject: Re: [PATCH v10 10/10] arm_ffa: efi: corstone1000: enable MM communication To: Abdellatif El Khlifi Cc: Drew.Reed@arm.com, achin.gupta@arm.com, Ilias Apalodimas , Jens Wiklander , nd , Rob Herring , Sudeep Holla , Tom Rini , U-Boot Mailing List , Xueliang Zhong Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.39 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Abdellatif, On Wed, 29 Mar 2023 at 05:12, Abdellatif El Khlifi < abdellatif.elkhlifi@arm.com> wrote: > > turn on EFI MM communication > > On corstone1000 platform MM communication between u-boot > and the secure world (Optee) is done using the FF-A bus. > > Signed-off-by: Abdellatif El Khlifi > Cc: Tom Rini > Cc: Simon Glass > Cc: Ilias Apalodimas > Cc: Jens Wiklander > > --- > Changelog: > =============== > > v9: update copyright string > > v8: > > * drop OP-TEE configs from Corstone-1000 defconfig > > v7: > > * improve the definition of FFA_SHARED_MM_BUFFER_ADDR and > FFA_SHARED_MM_BUFFER_OFFSET > * update FFA_SHARED_MM_BUFFER_ADDR value > > v6: > > * corstone-1000: enable optee driver > * corstone-1000: remove CONFIG_ARM_FFA_EFI_RUNTIME_MODE from the defconfig > > v4: > > * corstone-1000: turn on EFI MM communication > > configs/corstone1000_defconfig | 2 ++ > include/configs/corstone1000.h | 15 +++++++++++++-- > 2 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/configs/corstone1000_defconfig b/configs/corstone1000_defconfig > index 74250c7524..a7bfcbb2b9 100644 > --- a/configs/corstone1000_defconfig > +++ b/configs/corstone1000_defconfig > @@ -52,3 +52,5 @@ CONFIG_DM_SERIAL=y > CONFIG_USB=y > CONFIG_USB_ISP1760=y > CONFIG_ERRNO_STR=y > +CONFIG_EFI_MM_COMM_TEE=y > +CONFIG_ARM_FFA_TRANSPORT=y > diff --git a/include/configs/corstone1000.h b/include/configs/corstone1000.h > index 3347c11792..4ef1f05e40 100644 > --- a/include/configs/corstone1000.h > +++ b/include/configs/corstone1000.h > @@ -1,9 +1,11 @@ > /* SPDX-License-Identifier: GPL-2.0+ */ > /* > - * (C) Copyright 2022 ARM Limited > * (C) Copyright 2022 Linaro > * Rui Miguel Silva > - * Abdellatif El Khlifi > + * Copyright 2022-2023 Arm Limited and/or its affiliates < open-source-office@arm.com> > + * > + * Authors: > + * Abdellatif El Khlifi > * > * Configuration for Corstone1000. Parts were derived from other ARM > * configurations. > @@ -14,6 +16,15 @@ > > #include > > +#define FFA_SHARED_MM_BUFFER_SIZE SZ_4K /* 4 KB */ > + > +/* > + * shared buffer physical address used for communication between > + * u-boot and the MM SP > + */ > +#define FFA_SHARED_MM_BUFFER_ADDR 0x02000000UL > +#define FFA_SHARED_MM_BUFFER_OFFSET 0 > + > #define V2M_BASE 0x80000000 > > #define CFG_PL011_CLOCK 50000000 > -- > 2.25.1 > As a higher-level question, could this whole FFA implementation code be put into Linux or fwupd? Regards, Simon