From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Sun, 18 Sep 2016 18:58:43 -0600
Subject: [U-Boot] [PATCH 3/5] power: regulator: palmas: Add regulator
	support
In-Reply-To: <1473827299-29944-4-git-send-email-j-keerthy@ti.com>
References: <1473827299-29944-1-git-send-email-j-keerthy@ti.com>
 <1473827299-29944-4-git-send-email-j-keerthy@ti.com>
Message-ID: <CAPnjgZ18PfLBKXN-RSzy-M_n34CjBq2Z44k03uP=y=aNk7wFfg@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 13 September 2016 at 22:28, Keerthy <j-keerthy@ti.com> wrote:
> The driver provides regulator set/get voltage
> enable/disable functions for palmas family of PMICs.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  drivers/power/regulator/Kconfig            |   8 +
>  drivers/power/regulator/Makefile           |   1 +
>  drivers/power/regulator/palmas_regulator.c | 460 +++++++++++++++++++++++++++++
>  3 files changed, 469 insertions(+)
>  create mode 100644 drivers/power/regulator/palmas_regulator.c

Reviewed-by: Simon Glass <sjg@chromium.org>

But please consider using dm_i2c_reg_read()

Also you have two blank lines at one point.