From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: crt0: Pass malloc base address
Date: Wed, 11 Nov 2015 13:26:40 -0700 [thread overview]
Message-ID: <CAPnjgZ18XKJHqCfAN8BA-kMCpScYufJXjDaHcUOHRq24Gr6pDA@mail.gmail.com> (raw)
In-Reply-To: <1447273397-22833-1-git-send-email-festevam@gmail.com>
Hi Fabio,
On 11 November 2015 at 13:23, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Commit 5ba534d247d418 ("arm: Switch 32-bit ARM to using generic global_data
> setup") causes malloc() to fail in SPL.
>
> The reason is that the GD_MALLOC_BASE is not passed anymore.
>
> Restore the code that passes malloc base so that we can have
> malloc working in SPL code again.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/lib/crt0.S | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/lib/crt0.S b/arch/arm/lib/crt0.S
> index 80548eb..d620126 100644
> --- a/arch/arm/lib/crt0.S
> +++ b/arch/arm/lib/crt0.S
> @@ -87,6 +87,10 @@ ENTRY(_main)
> mov sp, r0
>
> mov r0, #0
> +#if defined(CONFIG_SYS_MALLOC_F_LEN)
> + sub sp, sp, #CONFIG_SYS_MALLOC_F_LEN
> + str sp, [r9, #GD_MALLOC_BASE]
> +#endif
> bl board_init_f
>
> #if ! defined(CONFIG_SPL_BUILD)
> --
> 1.9.1
>
Thanks for digging into this. But this should be set up in board_init_f_mem():
#if defined(CONFIG_SYS_MALLOC_F) && \
(!defined(CONFIG_SPL_BUILD) || !defined(CONFIG_SYS_SPL_MALLOC_START))
top -= CONFIG_SYS_MALLOC_F_LEN;
gd->malloc_base = top;
#endif
Is it possible that the #ifdef logic is wrong for your board?
Regardds,
Simon
next prev parent reply other threads:[~2015-11-11 20:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 20:23 [U-Boot] [PATCH] ARM: crt0: Pass malloc base address Fabio Estevam
2015-11-11 20:26 ` Simon Glass [this message]
2015-11-11 20:41 ` Fabio Estevam
2015-11-11 21:00 ` Fabio Estevam
2015-11-11 21:08 ` Simon Glass
2015-11-11 21:24 ` Fabio Estevam
2015-11-11 21:49 ` Simon Glass
2015-11-12 6:57 ` Albert ARIBAUD
2015-11-12 12:48 ` Fabio Estevam
2015-11-12 15:59 ` Simon Glass
2015-11-12 16:13 ` Albert ARIBAUD
2015-11-14 2:12 ` Simon Glass
2015-11-14 15:23 ` Albert ARIBAUD
2015-11-11 20:33 ` Albert ARIBAUD
2015-11-11 20:49 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ18XKJHqCfAN8BA-kMCpScYufJXjDaHcUOHRq24Gr6pDA@mail.gmail.com \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.