From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87810C433F5 for ; Thu, 29 Sep 2022 10:03:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9A7D684D81; Thu, 29 Sep 2022 12:02:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="IVwqAL6K"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A211284CF2; Thu, 29 Sep 2022 12:01:18 +0200 (CEST) Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EFE4684CFE for ; Thu, 29 Sep 2022 12:01:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oi1-x234.google.com with SMTP id t62so1065996oie.10 for ; Thu, 29 Sep 2022 03:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=oOiYPkDwtLSZY7rLjc08KflOcXVp8rQpbcHt0fZtp00=; b=IVwqAL6Kw7bybvZ8VikP9pDk4yAEuPDE1HlcFP+OIwnCN28qdL4xsjtcavmPlwMLf0 WyEObzVuL68/OovWIF6SYVKwBKIJdeeqI9g6O8rZFiIrM0OE+geMFDUjYV8ZWkH2HaPK RSAWj97V/Cvry4aalVpo0LR3DUwsY/cGB7eKM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=oOiYPkDwtLSZY7rLjc08KflOcXVp8rQpbcHt0fZtp00=; b=trNL6gM24pqFLsgUSyoCSzJrVtMT4Ms0envcZ7Vx0xRH1S6zwFrjmIfrumB0MzWcrR iYFRnyZPVRd4ez8BZQVnkiehD/ahRE1cgCdgIMZ2eaS0vU8ZERfKRsb3CP0memQEcsWB R90/eAg3YEkiHp5k23v3k8sGodgZRqiH1vkBKJFkpV400KYbtGVUqlZWc9SrtRldu9Ze b3k9IKAZB3PxKCea9OrPZxm+nztCCHT1cw2NiIsHpMKI4UYbXEZYOWRCc0uVgjfi90UX L1AoV2EXF01fZA0XPQLfNX7OwWofOh/QNNwtqTeWlv2f01j+fq44jgbc5LMieECkIdGi Gcyg== X-Gm-Message-State: ACrzQf1aaBjDY6CxKWY/ohszoQVl+lZMVsAzR77tpJEort/I9H/fNvQB JzfJOx9nLWeS/PFU0aoSuIJ+RGY9Dw51LkbK2LwwLg== X-Google-Smtp-Source: AMsMyM4GeABYOwiIsSAYMD8lfcd/JyOA4gJbrJmFoyUTUTTl5b0ClNWMyPlkAODDxGrQuSj205RpagnCpevglfiozNc= X-Received: by 2002:a05:6808:f0a:b0:350:61ee:8306 with SMTP id m10-20020a0568080f0a00b0035061ee8306mr6370349oiw.170.1664445665528; Thu, 29 Sep 2022 03:01:05 -0700 (PDT) MIME-Version: 1.0 References: <7bf8aa436f4456433d06dd8c76fbf0cb5672bd35.1664314043.git.msuchanek@suse.de> In-Reply-To: <7bf8aa436f4456433d06dd8c76fbf0cb5672bd35.1664314043.git.msuchanek@suse.de> From: Simon Glass Date: Thu, 29 Sep 2022 04:00:47 -0600 Message-ID: Subject: Re: [PATCH v5 12/15] dm: blk: Do not use uclass_next_device_err To: Michal Suchanek Cc: U-Boot Mailing List , Heinrich Schuchardt , AKASHI Takahiro Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote: > > blk_first_device_err/blk_next_device_err uses > uclass_first_device_err/uclass_next_device_err for device iteration. > > Although the function names superficially match the return value from > uclass_first_device_err/uclass_next_device_err is never used > meaningfully, and uclass_first_device/uclass_next_device works equally > well for this purpose. > > In the following patch the semantic of > uclass_first_device_err/uclass_next_device_err will be changed to be > based on uclass_first_device_check/uclass_next_device_check breaking > this sole user that uses uclass_next_device_err for iteration. > > Signed-off-by: Michal Suchanek > --- > drivers/block/blk-uclass.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) Reviewed-by: Simon Glass