From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fdt: avoid bad MAKEALL status
Date: Thu, 19 Apr 2012 07:16:49 -0700 [thread overview]
Message-ID: <CAPnjgZ1=Q0=T_vZDZD47h3J65FHitO+0giUkX7pUrECYp=BOkQ@mail.gmail.com> (raw)
In-Reply-To: <1334839004-23158-1-git-send-email-wd@denx.de>
Hi Wolfgang,
On Thu, Apr 19, 2012 at 5:36 AM, Wolfgang Denk <wd@denx.de> wrote:
> Current versions of ?dtc ?always print a message like
>
> ? ? ? ?DTC: dts->dtb ?on file "dt.dtb.tmp"
>
> which cannot even be suppressed with "-qqq". ?To avoid incorrect
> MAKEALL status, we manually filter out this message. ?This is a bit
> complicated, as we have to make sure to set a correct return code.
See the discussion on this patch:
http://patchwork.ozlabs.org/patch/149833/
A patch to fix this has now been accepted to dtc. So if you update dtc
you should find this message goes away.
3cbf829 dtc: Remove spurious output on stderr
>
> Also, get rid of the temp file: dtc accepts "-" for stdin.
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> ---
> ?dts/Makefile | ? 10 +++++++---
> ?1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/dts/Makefile b/dts/Makefile
> index 8b13b23..914e479 100644
> --- a/dts/Makefile
> +++ b/dts/Makefile
> @@ -46,9 +46,13 @@ all: $(obj).depend $(LIB)
> ?DT_BIN := $(obj)dt.dtb
>
> ?$(DT_BIN): $(TOPDIR)/board/$(VENDOR)/dts/$(DEVICE_TREE).dts
> - ? ? ? cat $< | $(CPP) -P $(DTS_CPPFLAGS) - >$@.tmp
> - ? ? ? $(DTC) -R 4 -p 0x1000 -O dtb -o ${DT_BIN} $@.tmp
> - ? ? ? rm $@.tmp
> + ? ? ? rc=$$( \
> + ? ? ? ? ? ? ? cat $< | $(CPP) -P $(DTS_CPPFLAGS) - | \
> + ? ? ? ? ? ? ? { { $(DTC) -R 4 -p 0x1000 -O dtb -o ${DT_BIN} - 2>&1 ; \
> + ? ? ? ? ? ? ? ? ? echo $$? >&3 ; } | \
> + ? ? ? ? ? ? ? ? grep -v '^DTC: dts->dtb ?on file' ; \
> + ? ? ? ? ? ? ? } 3>&1 ) ; \
> + ? ? ? exit $$rc
>
> ?process_lds = \
> ? ? ? ?$(1) | sed -r -n 's/^OUTPUT_$(2)[ ("]*([^")]*).*/\1/p'
> --
> 1.7.7.6
>
Regards,
Simon
next prev parent reply other threads:[~2012-04-19 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 12:36 [U-Boot] [PATCH] fdt: avoid bad MAKEALL status Wolfgang Denk
2012-04-19 14:16 ` Simon Glass [this message]
2012-04-19 18:26 ` Wolfgang Denk
2012-04-19 18:32 ` Simon Glass
2012-04-21 14:48 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ1=Q0=T_vZDZD47h3J65FHitO+0giUkX7pUrECYp=BOkQ@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.