From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0978FC433EF for ; Thu, 9 Sep 2021 19:57:48 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17EE7610CE for ; Thu, 9 Sep 2021 19:57:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 17EE7610CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 96FCF83502; Thu, 9 Sep 2021 21:57:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="JWkSNmd5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5C1218350B; Thu, 9 Sep 2021 21:57:43 +0200 (CEST) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5FAD283501 for ; Thu, 9 Sep 2021 21:57:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wr1-x433.google.com with SMTP id m9so4222988wrb.1 for ; Thu, 09 Sep 2021 12:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XBKsboZXXlrPmfHyVrDCgEekknQEBs+chOTH6iD0YDU=; b=JWkSNmd5QvyTvERngHyIWa5B6hyPKb5ryJbNih2+rJ/AWq83Z6fnJdELTsP1ThnMbe TNU8SAPA4KimYfvTPjHkae0laq/bdOMm9ElbglbKC5heZGlisVhG0Dgc+RJsXWjUgaju lAFBZLI1Zg3OICt7CsoDfAYDZtQgSNQ7Xp/1o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XBKsboZXXlrPmfHyVrDCgEekknQEBs+chOTH6iD0YDU=; b=fECnustKF35+DaFjscbwuiPL57iHABTZfOqkMi3R8RJf9NbFi6zjlBFv0s5pKS3ioe WJHgaZcHKBEMyBIUEWviTz5uq1QmZTvQN4bx07cmT3MViOaXut7dcoV6gAPhwBAS+J+C 1G4WJSql+pgMjQdFgCpuH/JN2rt3U3gWlk6Be0X013jGpXLxCQICMgzuF7vcptV6IZt/ qv2QmANAT1J3yqt+KJjhRbz4ITitEGg02pmB1USnsYhQvJSS2282otiKR4oQp9a2Cwcq rXGPDsy9NMc2Un3tPJxbgMePZZRGLpT7YRMAyzASkI3VrbZIODWMPstVRLfKeXxylniv 7GrQ== X-Gm-Message-State: AOAM532il01pZ78cjwZ1QsOzrDUamDP6az3b4cpkJTaKUdhW/lN+uttw Hkgs3/kWe85/CM956U2FEyR25EQmhPixoEopS90+1Q== X-Google-Smtp-Source: ABdhPJxjJeEaxUCVPSOmjSLBbMrZA+OpsPSKsCyewE/dthctjDSHC3cf5Xr7UdquIDE+CbebBs6lH8XRRELTbREJGNQ= X-Received: by 2002:adf:b7c5:: with SMTP id t5mr5638346wre.322.1631217459504; Thu, 09 Sep 2021 12:57:39 -0700 (PDT) MIME-Version: 1.0 References: <20210908133405.696481-1-sjg@chromium.org> <20210908073355.2.If4a31ab38420baccea0f0caf799c85966900e784@changeid> <80db89d7-1dd9-3029-b3cd-ed8c961f1107@gmx.de> In-Reply-To: <80db89d7-1dd9-3029-b3cd-ed8c961f1107@gmx.de> From: Simon Glass Date: Thu, 9 Sep 2021 13:57:27 -0600 Message-ID: Subject: Re: [PATCH 02/35] x86: Create a new header for EFI To: Heinrich Schuchardt Cc: U-Boot Mailing List , Ilias Apalodimas , Bin Meng , Tom Rini , Christian Melki Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, On Thu, 9 Sep 2021, 10:25 Heinrich Schuchardt, wrote: > > > > On 9/9/21 10:57 AM, Simon Glass wrote: > > Hi Heinrich, > > > > On Wed, 8 Sept 2021 at 11:27, Heinrich Schuchardt wrote: > >> > >> > >> > >> On 9/8/21 3:33 PM, Simon Glass wrote: > >>> The setup routines are called from zimage but don't really belong in the > >>> zimage header. Add a new EFI header to house these. Add comments so it is > >>> clear what the functions do. > >>> > >>> Signed-off-by: Simon Glass > >>> --- > >>> > >>> arch/x86/include/asm/efi.h | 32 ++++++++++++++++++++++++++++++++ > >>> arch/x86/include/asm/zimage.h | 3 --- > >>> arch/x86/lib/zimage.c | 1 + > >>> 3 files changed, 33 insertions(+), 3 deletions(-) > >>> create mode 100644 arch/x86/include/asm/efi.h > >> > >> In the future we should be able to run the EFI app on any UEFI > >> architecture. Given this background are the function definitions really > >> x86 specific? > > > > Well firstly that seems like that would be future work for someone. > > I did not expect that you do that work. But we should not make that work > more difficult than necessary. > > > Secondly, this relates to zimage which is really only used by x86 as > > far as I am aware. > > setup_video() and setup_efi_info() do not sound like zImage nor like x86 > specific. But actually they are. Please can you take a closer look? This is just using existing code... Regards, Simon