From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82B26C433EF for ; Fri, 24 Sep 2021 02:49:12 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04F4C610C9 for ; Fri, 24 Sep 2021 02:49:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 04F4C610C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7A60680202; Fri, 24 Sep 2021 04:49:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="L/Y3dF2k"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 86A2F8343F; Fri, 24 Sep 2021 04:49:01 +0200 (CEST) Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C66AA80202 for ; Fri, 24 Sep 2021 04:48:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa33.google.com with SMTP id h132so3389043vke.8 for ; Thu, 23 Sep 2021 19:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iwh5V5IlvZpbGPraHcZc0SbnsVmKPg3KfVLYV46aSQ0=; b=L/Y3dF2kXdQ02bHllfx0+VqAN49s0lJoQn1hhHpu01QZs+GzMzWsefrc+h9AJ1IILp uAj5Lt0P83lHxkCLfimdWWKgcshZA9SuPD7i0jNrwBRo8vMxM/G7+KcOy/96ZzqWfenb mLgNp3g21zRvnjHx0Ebh7rU+fCP2pMp19Dz1c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iwh5V5IlvZpbGPraHcZc0SbnsVmKPg3KfVLYV46aSQ0=; b=JAFuKvrbbK2PXbu2vTh+tihW1VsL+8pSotGzADZ2jeWt2gpM8Qq8IjTaXNY6/T6sCb a3fL/mc6n0TYPrIFnArEa30UpvNxvZUp9r/b6sOU25ioBH00x8YaGs0r7j/DuPy1DYv8 BGUWyLpsVEpYDGw8bLx9brUh/SyVyCsgbCuyNpsvPgwkqd9qVpemNnW5buz0F26btfE6 EIL+MzlpuYkjmbReA5C4ELROz9efAFfmaBn/vFAfwJDkJPUQaYWGwvZMJ69MmxHQFPLe g8wI8UjP+Ce5Q8z6vEMkM8Y59Hpfn7dEc4tmkJPXvqAcfAezchZqWEvNE8H053i5gnXU 7Ocw== X-Gm-Message-State: AOAM53053gFeCfK2ciIoCbl6ZwrYVgMIXLWCdBLIrQ3us6g3qwLk+wO/ uh6sJBCS8p6fgaoThV/E45HvtBwjES2oharXcqYx0oLs1aE= X-Google-Smtp-Source: ABdhPJzWolUsw0br8NMZPAGN7n2N+doV5N8kQlYeqyFGCJ1k9IClr4lHGY/SnELkjVnSxA+4FVGIy2BXR/CFHSzLBmY= X-Received: by 2002:a1f:ad46:: with SMTP id w67mr6529233vke.16.1632451733287; Thu, 23 Sep 2021 19:48:53 -0700 (PDT) MIME-Version: 1.0 References: <20210908133405.696481-1-sjg@chromium.org> <20210908073355.11.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> <56144ca004c70ce9@bloch.sibelius.xs4all.nl> <20210909202308.GG12964@bill-the-cat> <56144d0e41952059@bloch.sibelius.xs4all.nl> In-Reply-To: <56144d0e41952059@bloch.sibelius.xs4all.nl> From: Simon Glass Date: Thu, 23 Sep 2021 20:48:42 -0600 Message-ID: Subject: Re: [PATCH 11/35] RFC: efi: Drop code that doesn't work with driver model To: Mark Kettenis Cc: Tom Rini , Heinrich Schuchardt , U-Boot Mailing List , Ilias Apalodimas , Bin Meng , Christian Melki , Alex Graf Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Mark, On Thu, 9 Sept 2021 at 15:45, Mark Kettenis wrote: > > > Date: Thu, 9 Sep 2021 16:23:08 -0400 > > From: Tom Rini > > > > On Thu, Sep 09, 2021 at 10:15:44PM +0200, Mark Kettenis wrote: > > > > From: Simon Glass > > > > Date: Thu, 9 Sep 2021 13:57:39 -0600 > > > > > > > > Hi Heinrich, > > > > > > > > On Thu, 9 Sept 2021 at 03:26, Heinrich Schuchardt wrote: > > > > > > > > > > > > > > > > > > > > On 9/9/21 10:57 AM, Simon Glass wrote: > > > > > > Hi Heinrich, > > > > > > > > > > > > On Wed, 8 Sept 2021 at 11:44, Heinrich Schuchardt wrote: > > > > > >> > > > > > >> > > > > > >> > > > > > >> On 9/8/21 3:33 PM, Simon Glass wrote: > > > > > >>> This code should never have been added as it builds a new feature on top > > > > > >>> of legacy code. Drop it and add a dependency on BLK for this feature. > > > > > >>> > > > > > >>> Boards which want EFI_LOADER should migrate to driver model first. > > > > > >>> > > > > > >>> Signed-off-by: Simon Glass > > > > > >> > > > > > >> This patch is not related to the rest of the series and the code has a > > > > > >> different maintainer. > > > > > >> > > > > > >> So, please, separate it from the series. > > > > > > > > > > > > Who is the maintainer? > > > > > > > > > > Until 623b3a57976 ("efi_selftest: provide an EFI selftest application") > > > > > there was no official maintainer for lib/efi/ but you were the main > > > > > contributor. > > > > > > > > > > But with that patch directory lib/efi/ was assigned to EFI PAYLOAD. > > > > > > > > > > I am happy if you would continue to care about U-Boot on EFI. > > > > > > > > OK. > > > > > > > > > > > > > > > > > > > > > I need this patch for this series to work. You can still review things > > > > > > for other maintainers and in this case it is common for one maintainer > > > > > > to pick up the series once the others are happy. > > > > > > > > > > The direction of this patch is completely correct. > > > > > > > > > > There are some things that will have to be changed, e.g we should not > > > > > require CONFIG_DM_ETH=y. I will work on reviewing this patch in detail. > > > > > > > > OK, but why not require DM_ETH? The deadline passed a year ago. > > > > > > Because we support boards without network ports? > > > > Boards without networking should disable the relevant code, and as > > needed the EFI code return the proper error code? > > Yes, but it means you can't make DM_ETH a (hard) requirement for > EFI_LOADER support. What I mean is that it should still be possible > to build U-Boot with EFI_LOADER support even if DM_EFI isn't set for a > board. It should just result in a UEFI implementation with no network > support instead. I think you are misunderstanding my patch. I have: depends on DM_ETH || !NET which means that if NET is used, DM_ETH must be. I think that is reasonable. Regards, Simon