From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] efi_loader: rewrite README.efi
Date: Mon, 12 Feb 2018 13:42:08 -0700 [thread overview]
Message-ID: <CAPnjgZ1BJYtmUucdobs00rQ=QU_ZJPosTpLG65Y7s-y9NvzxwQ@mail.gmail.com> (raw)
In-Reply-To: <71A4933B-B6B1-4D94-B11D-5D283EA2C123@suse.de>
Hi Alex,
On 12 February 2018 at 12:41, Alexander Graf <agraf@suse.de> wrote:
>
>
>
> > Am 12.02.2018 um 15:35 schrieb Simon Glass <sjg@chromium.org>:
> >
> > Hi Alex,
> >
> >> On 9 February 2018 at 11:55, Alexander Graf <agraf@suse.de> wrote:
> >>
> >>
> >>> On 30.01.18 20:03, Heinrich Schuchardt wrote:
> >>> Provide information about
> >>>
> >>> - usage of the bootefi command
> >>> - overview of UEFI
> >>> - interaction between U-Boot and EFI drivers
> >>>
> >>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> >>> ---
> >>> v2
> >>> new file
> >>
> >> The patch is very hard to read. Please just make this 2 patches. One
> >> that removes the old file, one that adds the rewrite.
> >
> > That doesn't make a lot of sense to me. Can you not just apply the
> > patch locally and read it?
>
> That‘s what I did, but I doubt the occasional reviewer does it. He also rewrites the file completely, even changing copyright. So IMHO remove+add is the better way to express what is happening here.
Then perhaps the changes should be multiple patches? I agree it is
hard to review this sort of thing. But if you are happy with a
complete rewrite, then why not add a review tag? It doesn't much
matter that others cannot be bothered to review it properly. There is
some benefit to having a change history, I think.
Regards,
Simon
next prev parent reply other threads:[~2018-02-12 20:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 19:03 [U-Boot] [PATCH v2 0/2] efi_loader: update README.efi Heinrich Schuchardt
2018-01-30 19:03 ` [U-Boot] [PATCH v2 1/2] efi_loader: split README.efi into two separate documents Heinrich Schuchardt
2018-01-30 19:03 ` [U-Boot] [PATCH v2 2/2] efi_loader: rewrite README.efi Heinrich Schuchardt
2018-02-09 18:55 ` Alexander Graf
2018-02-12 14:35 ` Simon Glass
2018-02-12 19:41 ` Alexander Graf
2018-02-12 20:42 ` Simon Glass [this message]
2018-02-13 6:55 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPnjgZ1BJYtmUucdobs00rQ=QU_ZJPosTpLG65Y7s-y9NvzxwQ@mail.gmail.com' \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.