All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Nikhil M Jain <n-jain1@ti.com>
Cc: u-boot@lists.denx.de, agust@denx.de, devarsht@ti.com,
	trini@konsulko.com,  vigneshr@ti.com, nsekhar@ti.com
Subject: Re: [PATCH 3/9] cmd: Kconfig: Add necessary configs for splash screen at SPL
Date: Mon, 27 Mar 2023 21:23:56 +1300	[thread overview]
Message-ID: <CAPnjgZ1BaJdg8zSU4KmrYnhxHzEbvEoFJMK=VjhyWZKXxwtzVw@mail.gmail.com> (raw)
In-Reply-To: <20230314045019.5671-4-n-jain1@ti.com>

Hi Nikhil,

On Tue, 14 Mar 2023 at 17:50, Nikhil M Jain <n-jain1@ti.com> wrote:
>
> CONFIG_CMD_BMP and CONFIG_SPLASH_SCREEN enable's splash display at
> only u-boot proper. To enable splash display at SPL stage add SPL
> specific configs, which are SPL_CMD_BMP and SPL_SPLASH_SCREEN.
>
> Signed-off-by: Nikhil M Jain <n-jain1@ti.com>
> ---
>  cmd/Kconfig | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 2caa4af71c..2f7b820ab8 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1415,6 +1415,11 @@ config CMD_READ
>         help
>           Provides low-level access to the data in a partition.
>
> +config SPL_CMD_READ
> +       bool "read - Read binary data from a partition"
> +       help
> +         Provides low-level access to the data in a partition at SPL stage.
> +
>  config CMD_REMOTEPROC
>         bool "remoteproc"
>         depends on REMOTEPROC
> @@ -1931,6 +1936,18 @@ config CMD_BMP
>           the image into RAM, then using this command to look at it or display
>           it.
>
> +config SPL_CMD_BMP
> +       bool "Enable 'bmp' command"
> +       depends on SPL_VIDEO
> +       help
> +         This provides a way to obtain information about a BMP-format image
> +         and to display it in spl stage.BMP (which presumably stands for BitMaP) is a
> +         file format defined by Microsoft which supports images of various
> +         depths, formats and compression methods. Headers on the file
> +         determine the formats used. This command can be used by first loading
> +         the image into RAM, then using this command to look at it or display
> +         it.

For this you should split out a new CONFIG_BMP, since commands are not
enabled in SPL.

> +
>  config CMD_BOOTCOUNT
>         bool "bootcount"
>         depends on BOOTCOUNT_LIMIT
> --
> 2.34.1
>

Regards,
Simon

  reply	other threads:[~2023-03-27  8:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14  4:50 [PATCH 0/9] Enable splash screen Nikhil M Jain
2023-03-14  4:50 ` [PATCH 1/9] drivers: video: Kconfig: Necessary configs for video at SPL Nikhil M Jain
2023-03-14  6:50   ` Devarsh Thakkar
2023-03-27  8:23   ` Simon Glass
2023-03-14  4:50 ` [PATCH 2/9] drivers: video: tidss: Kconfig: Configs to enable TIDSS " Nikhil M Jain
2023-03-27  8:23   ` Simon Glass
2023-03-14  4:50 ` [PATCH 3/9] cmd: Kconfig: Add necessary configs for splash screen " Nikhil M Jain
2023-03-27  8:23   ` Simon Glass [this message]
2023-03-14  4:50 ` [PATCH 4/9] drivers: video: Makefile: Compile video driver files " Nikhil M Jain
2023-03-27  8:23   ` Simon Glass
2023-03-14  4:50 ` [PATCH 5/9] drivers: video: tidss: Makefile: Add condition to compile TIDSS " Nikhil M Jain
2023-03-27  8:23   ` Simon Glass
2023-03-14  4:50 ` [PATCH 6/9] cmd: Makefile: Add rules to build bmp.c and read.c " Nikhil M Jain
2023-03-27  8:24   ` Simon Glass
2023-03-14  4:50 ` [PATCH 7/9] common: splash: Enable splash_display at SPL stage Nikhil M Jain
2023-03-27  8:24   ` Simon Glass
2023-03-14  4:50 ` [PATCH 8/9] drivers: video: video-uclass: Disable u-boot logo at SPL Nikhil M Jain
2023-03-27  8:24   ` Simon Glass
2023-03-14  4:50 ` [PATCH 9/9] board: ti: am62x: evm: OSPI support for splash screen Nikhil M Jain
2023-03-27  8:24   ` Simon Glass
2023-03-14  5:54 ` [PATCH 0/9] Enable " Devarsh Thakkar
  -- strict thread matches above, loose matches on Subject: below --
2023-03-13 10:14 Nikhil M Jain
2023-03-13 10:14 ` [PATCH 3/9] cmd: Kconfig: Add necessary configs for splash screen at SPL Nikhil M Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ1BaJdg8zSU4KmrYnhxHzEbvEoFJMK=VjhyWZKXxwtzVw@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=agust@denx.de \
    --cc=devarsht@ti.com \
    --cc=n-jain1@ti.com \
    --cc=nsekhar@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.