From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E047C4332F for ; Wed, 12 Oct 2022 22:16:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5E2D384EDE; Thu, 13 Oct 2022 00:15:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="jvBDd/xH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3628484F13; Thu, 13 Oct 2022 00:15:09 +0200 (CEST) Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CAB8B84EDE for ; Thu, 13 Oct 2022 00:15:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wr1-x435.google.com with SMTP id r13so99260wrj.11 for ; Wed, 12 Oct 2022 15:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xymYxJzaFJO1PkzWjlU3VyD2djnUiiPGppcYhgjCASg=; b=jvBDd/xH4efVgJPKXK/hCSCkRZLdF2pmdCAgaFoQRJMFtFDbORfNxCJ99SEO4o2jP6 3IYoQU+/gjwdYyQRTlmsvV0kPoCPIXJZFh123E1MP2pAah9c7f2Op8I1GQBWk+oN3yq3 QUkbJwHa8edankgMXq5cbKgEnmmsdI2hsqd8c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xymYxJzaFJO1PkzWjlU3VyD2djnUiiPGppcYhgjCASg=; b=UgUMPZ07JlTqhVyAlb2JHjqoKDGgYtdbo04rWElmh/L+qO3YJDehQKK/JgrlS0nCKe w7t7MnwMlUga8PoOYwMIa5UIHgpsmltyPKqv80fj+lMuICDBUcG5SKctJOrHIebPdvnA FmobaQY5BRe+dJPYqiodOBhANBVJFSKPOtNSbmWCzOOcqFOxvqMRw/NbT0if8nMTIe9J 1V8gxfV+X3uTfchV0kRVs3Cgez/WuGX196NG8ke1eJfcDd0r6h9fwJJX+PCQz4NboOtf 0GfcR/npA60Yi04WD1oYPFBKtbNzPwRdVwKP9ynfqNdCq/jhhVyKoXzAvj3if+1/YDzb fLEw== X-Gm-Message-State: ACrzQf3DIiXzas8xdU4Y3XV+TaaLnMLRneXfEjMTM112ziGb2W3ZkDxd zhRrMvDdu1hW5jkLQugkar8AQdiSCPeDL6r1dLXD4A== X-Google-Smtp-Source: AMsMyM67BoLf3LtJXMJt1DHJfkb9OlGa/L5Sc8oaektxAq51h+jJXTX4jPI3/5I+nvKmLXx5ndi3vgS2O+pKBIBkvm8= X-Received: by 2002:a5d:598d:0:b0:230:f238:a485 with SMTP id n13-20020a5d598d000000b00230f238a485mr9832955wri.71.1665612901579; Wed, 12 Oct 2022 15:15:01 -0700 (PDT) MIME-Version: 1.0 References: <3de2290f134bc41dfab1f5f65d9a53c1cdaa4ede.1665604425.git.msuchanek@suse.de> In-Reply-To: <3de2290f134bc41dfab1f5f65d9a53c1cdaa4ede.1665604425.git.msuchanek@suse.de> From: Simon Glass Date: Wed, 12 Oct 2022 16:14:48 -0600 Message-ID: Subject: Re: [PATCH v6 14/20] dm: pci: Update error handling in pci_sriov_init To: Michal Suchanek Cc: u-boot@lists.denx.de, Andrew Scull , Bin Meng , Stefan Roese , =?UTF-8?Q?Pali_Roh=C3=A1r?= , =?UTF-8?Q?Pierre=2DCl=C3=A9ment_Tosi?= , Heinrich Schuchardt Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wed, 12 Oct 2022 at 13:58, Michal Suchanek wrote: > > Check the returned value from pci_get_bus. After a later patch > uclass_first_device_err may return a device on error and then checking > that a device is returned will not suffice. > > Signed-off-by: Michal Suchanek > --- > v6: - split off as separate patch > --- > drivers/pci/pci-uclass.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Simon Glass