From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] disk: part: avoid undefined reference to `__udivmoddi4'
Date: Sat, 22 Jun 2019 20:10:54 +0100 [thread overview]
Message-ID: <CAPnjgZ1CmMbaDzJYruKo4+NyFkpoK5NKE_tg+4WiOfuEQc-FsQ@mail.gmail.com> (raw)
In-Reply-To: <20190602083551.3207-1-xypron.glpk@gmx.de>
On Sun, 2 Jun 2019 at 09:36, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> When compiling with FTRACE=1 an error
>
> ld.bfd: disk/built-in.o: in function `lba512_muldiv':
> disk/part.c:114: undefined reference to `__udivmoddi4
>
> occurred.
>
> Use '>> 11' instead of '/ 2048' to avoid the division.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> disk/part.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Looks OK but I think you should rename div_by to shift_right, or similar.
- SImon
next prev parent reply other threads:[~2019-06-22 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 8:35 [U-Boot] [PATCH 1/1] disk: part: avoid undefined reference to `__udivmoddi4' Heinrich Schuchardt
2019-06-22 19:10 ` Simon Glass [this message]
2019-06-22 19:24 ` Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ1CmMbaDzJYruKo4+NyFkpoK5NKE_tg+4WiOfuEQc-FsQ@mail.gmail.com \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.