From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99515C07E95 for ; Sun, 4 Jul 2021 20:15:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D50E2613C2 for ; Sun, 4 Jul 2021 20:15:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D50E2613C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A63FE82BD5; Sun, 4 Jul 2021 22:15:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="bBcSFdwb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 665B582BB4; Sun, 4 Jul 2021 22:15:32 +0200 (CEST) Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DA9FC82B20 for ; Sun, 4 Jul 2021 22:15:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wm1-x32c.google.com with SMTP id w13so9979697wmc.3 for ; Sun, 04 Jul 2021 13:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:from:in-reply-to:references:date:message-id :subject:to:cc; bh=LPaNob7VGOtG9IscwvcphTBEK4DD0L3bXH58iafMLT4=; b=bBcSFdwb/0kRj3ZasdkeqebKEsW+CiZd4Rea2aAd4qqqWper/JC5Hdj10aef0r3jqY WiIWhYRn/6rGbu993raXMDG55RLG5Rh5ixSY9Ozdps6QRxju7brIkBkqF7lRJjrqHLxk xb7uaIyB5teXqOqE+NsdZ81u9tlU90D/dfSkA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:in-reply-to:references :date:message-id:subject:to:cc; bh=LPaNob7VGOtG9IscwvcphTBEK4DD0L3bXH58iafMLT4=; b=HaxlVUBPgP0NkVk88fMqJfbRUqRXGNDFmg+FYzrZcGF8poRlZNSa2TGF6Q+xSdZuIn B0H23DLq/HKSj720iKIfYrhNIJZ3sMnGDCiHyxOu58Syp7BaKq0EkBUKqtk9hdvvXL8Y X+RExadMSpsVX12zlaaWsw/Pj/AnZRL3G4s3gk1EW1gWQBtt+4xtxFErETbMRXn4ZB+F rmCFxvNxlvk0E0jXU6ZXkNdW2tZJpYCAaBaZ/nkgpIbNW4rlx1U8OxTQQbjT7t0shjih r8WxO4/yQEkt1mLR9mLdfWDL0tlCnWDU4YQ8BfePMyQRtVFMthhJVnNhD3ui7odZX3/M DJCQ== X-Gm-Message-State: AOAM533yv10k2CTbHcWNfDJr5o7X8EoZnO+z6cFzi13mKQI2Y79E5HEL xab6S2G8dvHZ+xdrVcgqUjZZNgfW5EOrFKRSUejLTA== X-Google-Smtp-Source: ABdhPJxrlirbMzNTDUM+nfWZsRN1Je84npovkBw/t3k0Iyh6qTFHY5AVUfNRvupgfJ7yRv5qYf6ftxvD2lLXWVEZOWU= X-Received: by 2002:a05:600c:3391:: with SMTP id o17mr10997837wmp.119.1625429729258; Sun, 04 Jul 2021 13:15:29 -0700 (PDT) Received: from 480794996271 named unknown by gmailapi.google.com with HTTPREST; Sun, 4 Jul 2021 13:15:26 -0700 MIME-Version: 1.0 From: Simon Glass In-Reply-To: References: <20210519160811.183102-1-rasmus.villemoes@prevas.dk> Date: Sun, 4 Jul 2021 13:15:26 -0700 X-Google-Sender-Auth: XNCvOr6-mDv317thpPPoLD23VTI Message-ID: Subject: Re: [PATCH] remove struct uclass_driver::ops To: Simon Glass Cc: U-Boot Mailing List , Tom Rini , Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, 19 May 2021 at 10:08, Rasmus Villemoes wrote: > > Each _device_ belonging to a given uclass of course has its own ->ops, > of a type determined by and known to the uclass. > > However, no instance of a uclass_driver seems to populate ->ops, and > the only reference to it in code is this relocation. > > Moreover, it's not really clear what could sensibly be assigned; it > would have to be some "struct uclass_ops *" providing a set of methods > for the core to call on that particular uclass, but should the need > for that ever arise, it would be better to have a member of that > particular type instead of void*. > > Signed-off-by: Rasmus Villemoes > --- > drivers/core/root.c | 3 --- > include/dm/uclass.h | 3 --- > 2 files changed, 6 deletions(-) Reviewed-by: Simon Glass Applied to u-boot-dm/next, thanks!