All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: Tom Rini <trini@konsulko.com>,
	U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/2] Makefile: Fix dependency for u-boot-with-dtb.bin
Date: Mon, 1 Aug 2022 13:13:21 -0600	[thread overview]
Message-ID: <CAPnjgZ1DoSF9eDsE76p_tw-N_Gr6A7AAeSzTYbZyhyNzecK0LA@mail.gmail.com> (raw)
In-Reply-To: <20220801154220.20068-1-pali@kernel.org>

On Mon, 1 Aug 2022 at 09:43, Pali Rohár <pali@kernel.org> wrote:
>
> Makefile uses binman to produce u-boot-with-dtb.bin target. As its input it
> takes DTB file and u-boot binary without DTB, which is stored in file
> u-boot-nodtb.bin. So fix target dependency.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index ff25f9297486..dcfcd7ebd5d2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1628,7 +1628,7 @@ u-boot-with-nand-spl.sfp: u-boot-spl-padx4.sfp u-boot.img FORCE
>  endif
>
>  ifeq ($(CONFIG_MPC85xx)$(CONFIG_OF_SEPARATE),yy)
> -u-boot-with-dtb.bin: u-boot.bin u-boot.dtb \
> +u-boot-with-dtb.bin: u-boot-nodtb.bin u-boot.dtb \
>         $(if $(CONFIG_MPC85XX_HAVE_RESET_VECTOR), u-boot-br.bin) FORCE
>         $(call if_changed,binman)
>
> --
> 2.20.1
>

Reviewed-by: Simon Glass <sjg@chromium.org>

But I feel this should be dropped and be handled by the normal binman
rule in the Makefile.

  parent reply	other threads:[~2022-08-01 19:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-01 15:42 [PATCH 1/2] Makefile: Fix dependency for u-boot-with-dtb.bin Pali Rohár
2022-08-01 15:42 ` [PATCH 2/2] Makefile: Build final mpc85xx non-SPL image in standard file u-boot.bin Pali Rohár
2022-08-01 17:40   ` Tom Rini
2022-08-01 19:13   ` Simon Glass
2022-08-01 19:39     ` Pali Rohár
2022-08-01 23:15       ` Tom Rini
2022-08-03 11:28         ` Pali Rohár
2022-08-17 21:07           ` Pali Rohár
2022-08-17 22:44             ` Simon Glass
2022-08-21 12:17               ` Tom Rini
2022-09-07  9:22                 ` Pali Rohár
2022-08-01 17:40 ` [PATCH 1/2] Makefile: Fix dependency for u-boot-with-dtb.bin Tom Rini
2022-08-01 19:13 ` Simon Glass [this message]
2022-08-31 12:03 ` Pali Rohár
2022-08-31 12:12   ` Tom Rini
2022-09-07  9:21 ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ1DoSF9eDsE76p_tw-N_Gr6A7AAeSzTYbZyhyNzecK0LA@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=pali@kernel.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.