From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 339E9C433F5 for ; Mon, 13 Dec 2021 12:52:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B434C83788; Mon, 13 Dec 2021 13:52:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="D8V/mdWt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D29C883777; Mon, 13 Dec 2021 13:52:05 +0100 (CET) Received: from mail-vk1-xa35.google.com (mail-vk1-xa35.google.com [IPv6:2607:f8b0:4864:20::a35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BF7868376D for ; Mon, 13 Dec 2021 13:51:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa35.google.com with SMTP id h1so10337316vkh.0 for ; Mon, 13 Dec 2021 04:51:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ytl4MtQNzievYzU/ViW89/HgDKx0jO/9EyOFW7LMnwc=; b=D8V/mdWtDgBxyvxWiHwjMlkzGjnS254y4u80dNY87razEAmsDW+eRDFd0T0txZYxUx IzICMmLQLklxrRb3a95xBwCdvVbgs35h1fItRrcf5ihinZGpRCeDVfyL5GvNrQNpt6d7 xogkyofSIl2NVxJnW4rJMEtu6/nWCCkAmOY9k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ytl4MtQNzievYzU/ViW89/HgDKx0jO/9EyOFW7LMnwc=; b=3TFUgAfN/fXd+FgcMRE51w5O03s/OIhRcabq72gio9JNOztd0Pn9Gshn9BV8PONFW/ EALPmZPhCF3q8hcr0LIkXTBpwpo/ekEg3sW8IEyPQIivrMVRO+/nAhDAm/NKDcVMcxxD 8/7U9XU9G5Y33v2lO402VdQ2Opp+XwqzrHQHSsUa81NDAz/Kdkv4xkAKwBfUWytYvzB0 LMvFTGn8NnQJHq9mAvGPnaAnEu5j9EiqhfUDiMuQ+1Qm9/vEqeizYzFjVNpJ0EAB/9NL K6v4Fd9BDrJzD//yIJrVGWToiOikRRlHxX6qFp3YTZNlYXHIWF9jabd2coE6ynvKDFB6 A9mg== X-Gm-Message-State: AOAM530edCtlTbRdvmhxSgDv9rGllFYoS57K8gG6WSNAe1nJzuBxg/DF u7jrVv+kxROe3vrKsYN+pN7bkKOiSw80wQXJDxVhPnsDeQM= X-Google-Smtp-Source: ABdhPJwiYnceOBFoZjrV+FKPR/jmf4T3Ic5o7l7Sz6NAaxyhudg3qe+qDkSpZGY4bn7BMV1wN15kwky8pFqI2yJ6z0w= X-Received: by 2002:a05:6122:21a6:: with SMTP id j38mr32042763vkd.3.1639399916177; Mon, 13 Dec 2021 04:51:56 -0800 (PST) MIME-Version: 1.0 References: <20211210064947.73361-1-takahiro.akashi@linaro.org> <20211210064947.73361-13-takahiro.akashi@linaro.org> In-Reply-To: <20211210064947.73361-13-takahiro.akashi@linaro.org> From: Simon Glass Date: Mon, 13 Dec 2021 05:51:45 -0700 Message-ID: Subject: Re: [RFC v2 12/20] dm: add tag support To: AKASHI Takahiro Cc: xypron.glpk@gmx.de, agraf@csgraf.de, ilias.apalodimas@linaro.org, masami.hiramatsu@linaro.org, u-boot@lists.denx.de Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Takahiro, On Thu, 9 Dec 2021 at 23:58, AKASHI Takahiro wrote: > > With dm-tag feature, any U-Boot subsystem is allowed to associate > arbitrary number of data with a particular udevice. This can been > see as expanding "struct udevice" without modifying the definition. > > As a first user, UEFI subsystem makes use of tags to associate > an efi_disk object with a block device. > > Signed-off-by: AKASHI Takahiro > --- > drivers/core/Makefile | 2 +- > drivers/core/tag.c | 162 ++++++++++++++++++++++++++++++++++++++++++ > include/dm/tag.h | 76 ++++++++++++++++++++ > 3 files changed, 239 insertions(+), 1 deletion(-) > create mode 100644 drivers/core/tag.c > create mode 100644 include/dm/tag.h Needs comments and a test, but looks good. How does the list itself get inited? Regards, Simon