From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Tue, 29 Oct 2019 18:03:55 -0600
Subject: [U-Boot] [PATCH v2 2/5] tools: buildman: Remove useless mkdir()
 in Make() in test.py
In-Reply-To: <CAEUhbmXz3uMdcqMKHUPsXFdpZOWi-1FMfAH=BNHaD=mTi_YJgQ@mail.gmail.com>
References: <1572272704-31204-1-git-send-email-bmeng.cn@gmail.com>
 <1572272704-31204-3-git-send-email-bmeng.cn@gmail.com>
 <CAPnjgZ3ZiFJ4Et8vbRfnpL1Fyy+QT6PkstyWXj8TuS-rsen1Tw@mail.gmail.com>
 <CAEUhbmXz3uMdcqMKHUPsXFdpZOWi-1FMfAH=BNHaD=mTi_YJgQ@mail.gmail.com>
Message-ID: <CAPnjgZ1FgAqeceg-oN=fjo6fY12rSyhF9WnkoxjX3KBVLMAJJg@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Bin,

On Tue, 29 Oct 2019 at 07:56, Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Hi Simon,
>
> On Tue, Oct 29, 2019 at 11:37 AM Simon Glass <sjg@chromium.org> wrote:
> >
> > Hi Bin,
> >
> > On Mon, 28 Oct 2019 at 08:25, Bin Meng <bmeng.cn@gmail.com> wrote:
> > >
> > > In the 'Make' function, the codes tries to create a directory
> > > if current stage is 'build'. But the directory isn't used at
> > > all anywhere.
> > >
> > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> > >
> > > ---
> > >
> > > Changes in v2:
> > > - remove the unneeded debug codes
> > >
> > >  tools/buildman/test.py | 8 --------
> > >  1 file changed, 8 deletions(-)
> >
> > Can you check this works OK when there is no output dir at all? E.g.
> >
> > -o /path/to/a/deep/non-existent/dir
>
> If I understand the codes correctly the "O=<path>" in args[] does not
> come from "-o /path/to/a/deep/non-existent/dir" but from the
> builderthread with some hardcoded values. The removed codes here seem
> to do something not very useful.

That's fine, and TBH if we hit a problem later due to this we should
add a unit test to cover it.

Regards,
Simon