From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 435A7C433EF for ; Tue, 1 Mar 2022 14:59:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C00EC83BCA; Tue, 1 Mar 2022 15:58:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="AbUWdtjA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E026F83B73; Tue, 1 Mar 2022 15:58:54 +0100 (CET) Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0219383A92 for ; Tue, 1 Mar 2022 15:58:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x934.google.com with SMTP id f23so193613uam.0 for ; Tue, 01 Mar 2022 06:58:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hNNTjohhXU+EZzK6MOIXlWPr6tic9pAkyY0vzMMq+H0=; b=AbUWdtjARoJTgeouICGGczSRY1yhbrBEnt446m9c3juO7/fGGshsCtHxGHLuX6z/Wl awxs7n8NdfhLrqu5h2UePRSFdnyw7W4XN7XWbR+gppwTrOfVH00/IErx2GMI4Z1vx9MG qXuZrlGipvvTmHluUbCDlRFzXXzWouIUUdxCk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hNNTjohhXU+EZzK6MOIXlWPr6tic9pAkyY0vzMMq+H0=; b=vGvSOVPQpSP4Ur8ScdV6te3Lknyv6VuenCeOhBgJRBPB6gpAGi5xivflgWVb74SoTK U3BdF5Z1LcgHCRn4AGqPjSUAVXWwy1i6DUyAafdg+cnV8FXoF1ZFrgPA3yUOowKJ7CJ4 F21e8rFkoz1wi+GKMGMft6mPOnuZCaZIORTm+lg9Mc/l3V2f/aWkZkZx52a1mTEVI3XW eULFlYm/99FYDBghg07B634Dd7ZLTZBQrvxx5OVT3oTr8PtZR6SI60xoedzVlf4Ct2iY cOLUOPyEqOpgWGx5ob4tbluMVgqSC2b36Mr9qD95A8Gf2bSEdVTmRSRn3ym25UptYNd4 LcCw== X-Gm-Message-State: AOAM533r1ZrnWgRhWWgAGKL5JO7XACgDx9e2bCXLe7tqihCA81WmKHvi x6zeHtjhAFkGA3gieK+KVe8/NEYx75NKwLt1LtG0kg== X-Google-Smtp-Source: ABdhPJzZU58lb4CH2dYnMWcvDi1lxD4TRKZuAL0wQHtlxBUs6j477vrzl0f1YlHF9rPe//bUTdtrk1Vw2mEKbnSPEEw= X-Received: by 2002:ab0:16d9:0:b0:342:4791:1b86 with SMTP id g25-20020ab016d9000000b0034247911b86mr9941936uaf.82.1646146727542; Tue, 01 Mar 2022 06:58:47 -0800 (PST) MIME-Version: 1.0 References: <839f475cc75c97ffb3496a4caa93de2faabdbca2.1645629688.git.michal.simek@xilinx.com> In-Reply-To: <839f475cc75c97ffb3496a4caa93de2faabdbca2.1645629688.git.michal.simek@xilinx.com> From: Simon Glass Date: Tue, 1 Mar 2022 07:58:34 -0700 Message-ID: Subject: Re: [PATCH] gpio: slg7xl45106: Add support for slg7xl45106 i2c gpo expander To: Michal Simek Cc: U-Boot Mailing List , git , T Karthik Reddy , Hannes Schmelzer , Heiko Schocher , Oleksandr Suvorov , Sebastian Reichel , Stephan Gerhold Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Michal, On Wed, 23 Feb 2022 at 08:21, Michal Simek wrote: > > From: T Karthik Reddy > > slg7xl45106 is i2c based 8-bit gpo expander, gpo pins are set and get by > writing and reading corresponding gpo bit value into its data register. > > Signed-off-by: T Karthik Reddy > Signed-off-by: Michal Simek > --- > > MAINTAINERS | 1 + > drivers/gpio/Kconfig | 8 +++ > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio_slg7xl45106.c | 115 ++++++++++++++++++++++++++++++++ > 4 files changed, 125 insertions(+) > create mode 100644 drivers/gpio/gpio_slg7xl45106.c You might consider reducing the length of the 'slg7xl45106_i2c_gpo' prefix. Also did you know about dm_i2c_reg_clrset() ? Reviewed-by: Simon Glass Regards, SImon