From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Thu, 11 Mar 2021 21:45:46 -0700 Subject: [PATCH v2] tee: optee: Change printing during optee_probe In-Reply-To: <20210310133511.3048227-1-ilias.apalodimas@linaro.org> References: <20210310133511.3048227-1-ilias.apalodimas@linaro.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Ilias, On Wed, 10 Mar 2021 at 06:35, Ilias Apalodimas wrote: > > Right now the error messages when optee has a version mismatch or shared > memory is not configured are done with a debug(). > That's not very convenient since you have to enable debugging to figure > out what's going on, although this is an actual error. The code that probes the device should report the error. If you put errors in a device driver it bloats the code and also it makes it impossible for the caller to suppress the error, e.g. if it is OK for the device to not probe. > > So let's switch the debug() -> dev_err() and report those explicitly. > > Signed-off-by: Ilias Apalodimas > Reviewed-by: Patrick Delaunay > --- > drivers/tee/optee/core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)