From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22EC8C4338F for ; Sun, 1 Aug 2021 19:20:37 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6047361075 for ; Sun, 1 Aug 2021 19:20:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6047361075 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 570D083280; Sun, 1 Aug 2021 21:19:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="mhCWK7YV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 71EEE832D6; Sun, 1 Aug 2021 21:19:49 +0200 (CEST) Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3F9558322E for ; Sun, 1 Aug 2021 21:19:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oi1-x236.google.com with SMTP id u25so21532621oiv.5 for ; Sun, 01 Aug 2021 12:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5xhMZkG7ykDfhw8LM/AQame+esoUdEBb4Ya+SpnFuX8=; b=mhCWK7YVY2B7bC5UCS13Sf4TXsegMdaiduc8AVSO0Ux2kxGwZFQkf7B81KygIUGACN LBfUlkWLc/GVQpQODbZ5vhjutv9Nuj73BIL4V3gfS2DZIIGZDs/v99WHegVO/NGhL0/Z 6b7PwUoZAXCUcEjTk+EbONXWtqClsEuXB+5ao= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5xhMZkG7ykDfhw8LM/AQame+esoUdEBb4Ya+SpnFuX8=; b=r/WmWTS8u5Gi0mMqqrdneHvhBGV9F01tsuhs/FK+XQtWojNZwP4+E6KYtxIjiR1yIw tB5idlVN2LdsLfYBEVLpNVkgSZhkeR5DmKlhRXhAVUg3zvCMSBbBMigfFvclXBjZTqvB 2+aVO9IFSipjCSM8Xj3Ig4ofs0t+6PlK1Pw77CBgK9o9NscB8TMtwb0llE1Iw+JyiGho 5gEpbEAp15Vv5YJog6Cn+ouYELCa7kfb0GrAjdoAYECdv+Ezux7XeePhr4zgN3DXMR9g S20EUlg8PmULoKD1m+uKdQ5yRXzKfFWTVWjAOQeLsX9qEhEn3TlolHMHEr7Nyh7gaSB5 L8ig== X-Gm-Message-State: AOAM530xCTjpDuXVWBgzvi80rUC2Mzy5S5myu6k4EIZwnvmSbRsF+I+M 9dfTdtn0e7YYPuBz3xC3pf3Z/VO+QKJJzu9v4tCDuw== X-Google-Smtp-Source: ABdhPJyTeecPlMn48IGeZDOqJDLuiG+1dcDi9Px61VcRRX+ttBXPEgukreY0k7uf568Qv7G29W/Ngxk3s5bjhD97dGc= X-Received: by 2002:a05:6808:f07:: with SMTP id m7mr8240218oiw.150.1627845578410; Sun, 01 Aug 2021 12:19:38 -0700 (PDT) MIME-Version: 1.0 References: <20210731084529.7524-1-bmeng.cn@gmail.com> <20210731084529.7524-4-bmeng.cn@gmail.com> In-Reply-To: <20210731084529.7524-4-bmeng.cn@gmail.com> From: Simon Glass Date: Sun, 1 Aug 2021 13:19:26 -0600 Message-ID: Subject: Re: [PATCH 3/7] x86: mtrr: Skip MSRs that were already programmed in mtrr_commit() To: Bin Meng Cc: U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sat, 31 Jul 2021 at 02:45, Bin Meng wrote: > > At present mtrr_commit() programs the MTRR MSRs starting from > index 0, which may overwrite MSRs that were already programmed > by previous boot stage or FSP. > > Switch to call mtrr_set_next_var() instead. > > Signed-off-by: Bin Meng > --- > > arch/x86/cpu/mtrr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass Tested on chromebook_coral, chromebook_samus, chromebook_link, minnowmax Tested-by: Simon Glass