From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5DA7C433EF for ; Fri, 15 Oct 2021 00:41:32 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9C05610A0 for ; Fri, 15 Oct 2021 00:41:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E9C05610A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3592F837C7; Fri, 15 Oct 2021 02:41:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="OsYCYY5I"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CDB718379F; Fri, 15 Oct 2021 02:40:45 +0200 (CEST) Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D3F36837B2 for ; Fri, 15 Oct 2021 02:40:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oi1-x233.google.com with SMTP id z126so10737992oiz.12 for ; Thu, 14 Oct 2021 17:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Mympx3gYx2pVTSuTvduSYoEL/UguBsUUpozCqVRdzr4=; b=OsYCYY5IwJA8sLHT1zTHBOrcydJg8fUXl2HYJoOZmTfiU9lT8QwG6xfzM+pKgOISVi mFUCKnDN/SCk/WChLtiaFzHocl663US9SjEU7h1XbcgV04GHZ05F/00KY0LHaRXRB65j 2DbEIyFm+c+phRR52omSsIV+2TGOSAYmiyvFM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Mympx3gYx2pVTSuTvduSYoEL/UguBsUUpozCqVRdzr4=; b=BpqF1dH/gCLmmwNxRh9rC3rHG0FjgIc932UAAuA3xY891ep13GFfpuERhjXyxFcP3M Onm6f6nJHD7uC0q7x+2/P8DDH8VHjY+2UAabFU2Zi+qb8Kb6yNrJEAKuTccwt0mNCvH5 Odxq5+hX/J7dVeTvw3B1+D4jeoKHMm/hO0fl7dr55r6EN+GdDfwy5EYmnyEbQpEeHiZ3 pSNZo7u+FS96QB5FPstGpVGdyb6rarxx2WsbRSWWrWN1Qo3FeDVPnpqKQ5C6RxmucDv1 kpszIm58lMK+ycFHy701i+3K/JX+WlAwxC6iwrJnmyrIjw9uwRnGs/oKHXoCUqJhnBU/ fqyw== X-Gm-Message-State: AOAM531SiMizVaafnP/qFw0pkgW5y8zo8bKfWI3h7cqho22nIisIuQ8S aDxyINwRtBPKaXgSHamLMJKj6NYuZYOY1AWYIWfgqw== X-Google-Smtp-Source: ABdhPJw4Si4WNTKe5VzuHN9vjuWId4GMKKA5eaM2x3utqYqwWbn1ZU5sDuXOSX046gj9yozwM8U6RqQGaZHqzXQ4CCM= X-Received: by 2002:a05:6808:189f:: with SMTP id bi31mr6346947oib.150.1634258436984; Thu, 14 Oct 2021 17:40:36 -0700 (PDT) MIME-Version: 1.0 References: <20211007062340.72207-1-takahiro.akashi@linaro.org> <20211007062340.72207-5-takahiro.akashi@linaro.org> <20211012014212.GC38222@laputa> In-Reply-To: <20211012014212.GC38222@laputa> From: Simon Glass Date: Thu, 14 Oct 2021 18:40:24 -0600 Message-ID: Subject: Re: [PATCH v4 04/11] tools: add fdtsig.sh To: AKASHI Takahiro , Simon Glass , Heinrich Schuchardt , Alex Graf , Ilias Apalodimas , Sughosh Ganu , Masami Hiramatsu , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Takahiro, On Mon, 11 Oct 2021 at 19:42, AKASHI Takahiro wrote: > > Simon, > > On Mon, Oct 11, 2021 at 08:54:09AM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Thu, 7 Oct 2021 at 00:25, AKASHI Takahiro wrote: > > > > > > With this script, a public key is added to a device tree blob > > > as the default efi_get_public_key_data() expects. > > > > > > Signed-off-by: AKASHI Takahiro > > > --- > > > MAINTAINERS | 1 + > > > tools/fdtsig.sh | 40 ++++++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 41 insertions(+) > > > create mode 100755 tools/fdtsig.sh > > > > Instead of an ad-hoc script with no tests, > > Basically I intended to provide fdtsig.sh as a *sample* script so that > people may want to integrate the logic into their own build rule/systems. > But I could use this script in my 'capsule authentication' test > that is also added in patch#22. > > > could we use binman for > > putting the image together and inserting it? > > First, as you can see, the script is quite simple and secondly, > the purpose of binman, IIUC, is to help handle/manipulate U-Boot > image binaries. > So I'm not sure whether it is really useful to add such a feature to binman. I'm not sure. The script seems very ad-hoc to me, for a feature that Linaro is pushing so hard. I don't see where the script is used in the tests or even mentioned in the documentation. Am I missing something? Regards, Simon