From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8760C433F5 for ; Thu, 3 Feb 2022 22:11:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1E96F83A47; Thu, 3 Feb 2022 23:11:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="i0jxGR4A"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9F33D83A48; Thu, 3 Feb 2022 23:11:14 +0100 (CET) Received: from mail-ua1-x929.google.com (mail-ua1-x929.google.com [IPv6:2607:f8b0:4864:20::929]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9BD3583A3D for ; Thu, 3 Feb 2022 23:11:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x929.google.com with SMTP id b37so7749139uad.12 for ; Thu, 03 Feb 2022 14:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=4hkulnUIth9bNWvUuDJgS/llKIwxZx+0OJVoju85WNQ=; b=i0jxGR4AM0ILpg5ka8PPnlNEN97QE6CF1viCjzEFTLcVO5Aw7XoagfOUQq2Cc0Scsg AwSuh/tVc3rqEB20QCxQFqBlA0JnOXqwp5FmysjGRodn2uFV3qP6iXLiCU3LFWdAtGSB JKLfXDhi3glYbq4nnWdcq4pIUK5klLBxhDX8k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4hkulnUIth9bNWvUuDJgS/llKIwxZx+0OJVoju85WNQ=; b=upJRrE1/HvAtp99WaI9ed04MSWKJ4ilMm3LG05/e7Pzi+F3jE+CJobUzyMRTBAGTjj 9y7FBbewOsv/9VUGqkK80OIlifsOWurrFxytEv4iKoDAqShOPoYY9XuW6JGTn7ilr4CJ kKWa4jU3vT2EG56AahGjbKAZXDJ6a//0PzROt1unidz0kB0ygegOVAr8OtK2uZuxln1Z fJL9VvLDqjStvkIEoquu9SO5AH+mkz0/27xN7y2yW7lcWyl9KuvKfVt2ZfeeD8bUW+mV Im3tWMjeF7P98cs3PAqUwSUVpn3BKT47NO/QMyl+wzNUYNQpjbpe/Eq9MCgWmztan/W4 rciA== X-Gm-Message-State: AOAM5338ZZI5RiYTWwpa1UUutnFoToDEyTeoQ+IhwvefpEQkqthUCp0z 3TRHPVX0yVx6/gE+Ax3aWLI3N+9fusl8gR4U7z2BZg== X-Google-Smtp-Source: ABdhPJzE7Ctl2joxL95M8q8wZo7he+lQROWRg5JeVJ7Mp9nNbzQm0PjYGyPT4yKwclEr3M9nB0xe0+Acf0rNM13Tnfs= X-Received: by 2002:a67:c296:: with SMTP id k22mr14050141vsj.19.1643926269895; Thu, 03 Feb 2022 14:11:09 -0800 (PST) MIME-Version: 1.0 References: <20220203183850.10186-1-pali@kernel.org> <20220203211623.GY7515@bill-the-cat> <20220203214544.GA7515@bill-the-cat> <20220203215307.GB7515@bill-the-cat> <20220203220918.GC7515@bill-the-cat> In-Reply-To: <20220203220918.GC7515@bill-the-cat> From: Simon Glass Date: Thu, 3 Feb 2022 15:10:58 -0700 Message-ID: Subject: Re: [PATCH] Nokia RX-51: Convert to CONFIG_DM_KEYBOARD To: Tom Rini Cc: =?UTF-8?Q?Pali_Roh=C3=A1r?= , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Thu, 3 Feb 2022 at 15:09, Tom Rini wrote: > > On Thu, Feb 03, 2022 at 03:03:21PM -0700, Simon Glass wrote: > > Hi, > > > > On Thu, 3 Feb 2022 at 15:02, Simon Glass wrote: > > > > > > Hi, > > > > > > On Thu, 3 Feb 2022 at 14:53, Tom Rini wrote: > > > > > > > > On Thu, Feb 03, 2022 at 04:45:44PM -0500, Tom Rini wrote: > > > > > On Thu, Feb 03, 2022 at 04:16:23PM -0500, Tom Rini wrote: > > > > > > On Thu, Feb 03, 2022 at 07:38:50PM +0100, Pali Roh=C3=A1r wrote= : > > > > > > > > > > > > > Signed-off-by: Pali Roh=C3=A1r > > > > > > > --- > > > > > > > > > > > > > > I would really appreciate if U-Boot test framework starts pri= nting > > > > > > > deprecation warnings, instead of sending patches which direct= ly drop > > > > > > > support for some boards. > > > > > > > > > > > > > > There is absolutely no warning during building U-Boot for RX-= 51 board > > > > > > > that this board has not been converted to DM_KEYBOARD yet. > > > > > > > > > > > > Please send some patch that implements what you're wanting to s= ee for > > > > > > how to make the warnings more visible. I do agree the warning = for > > > > > > v2022.10 only showed up after the merge to -next once v2022.01 = came out, > > > > > > but it's still a fairly long time to clean up the few unconvert= ed > > > > > > boards. > > > > > > > > > > Oh, I see what's going on. Simon, the DM_KEYBOARD check isn't > > > > > triggering for any boards. I'll look more. > > > > > > > > And here's where we're at. nokia_rx51 doesn't set CONFIG_KEYBOARD,= so > > > > didn't trigger the warning about migration. Every platform that s= ets > > > > CONFIG_KEYBOARD is migrated. I don't know how many other platforms= are > > > > in the situation nokia_rx51 is in. Yanking out the legacy code and > > > > seeing what fails to build, and going from there is probably the ne= xt > > > > option. > > > > > > Yes. > > > > > > As to your questoin, none that I know of. I sent a series to drop > > > cfb_console which was how this used to work, although in fact it > > > hasn't worked for a while. The problem here seems to be that this > > > board was multiple migrations behind and so was not caught. > > > > > > We should be able to remove the migration check. > > > > > > Pali, just to explain from the other POV, I am finding it increasingl= y > > > frustrating dealing with ad-hoc CONFIG options, old drivers, etc. We > > > really need to complete some of the migrations we started 6 years ago= . > > > > BTW the keyboard driver should go in drivers/input and should use > > device tree, not platdata. > > This is likely one of the cases where we end up saying a platform is > only platdata, given size concerns? That's my quick recollection from > talking about the USB stuff a few months back, and some other related > size questions. OK, I see. Yes, device tree would add a lot (in fact it doesn't even use OF_CONTROL). Regards, Simon