From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6969CC433F5 for ; Wed, 3 Nov 2021 01:33:15 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C72EC604DC for ; Wed, 3 Nov 2021 01:33:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C72EC604DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 90BD38329E; Wed, 3 Nov 2021 02:33:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="NjqHxqgr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 329DC83325; Wed, 3 Nov 2021 02:33:10 +0100 (CET) Received: from mail-vk1-xa31.google.com (mail-vk1-xa31.google.com [IPv6:2607:f8b0:4864:20::a31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B667C8320D for ; Wed, 3 Nov 2021 02:33:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-vk1-xa31.google.com with SMTP id a129so548288vkb.8 for ; Tue, 02 Nov 2021 18:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vTIut1ymaDabKkqB12mW1+gOwQtugPp4jFZ8ypIxeAs=; b=NjqHxqgrxFsZ0bsh2dnhaItxtifP9aRWI/v5WRQ10YASsasvPWQwPqvaL72TPOQAvK a6Tpenu/eI09r6zipxqhk6IN93iuU5Qgy8iUtzZIT6hS+mCUhoVzEnHXCLqhwU1qL8pF jf6e1Ot/5vr/spLOL6wbjl3Poe+knDXN2EiiE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vTIut1ymaDabKkqB12mW1+gOwQtugPp4jFZ8ypIxeAs=; b=WXXjBh52/p/adcEvhQ/yu/ImOlf83er1SI5aLSXveL0ajEt2q1uxXL+uRPbgibXmCP 9SUjF/eQanmy7p67k5BHxCxc37acTG+4AhrQlCA9yRrQBcNPT+yIDcskA/7f7FT2PDLw ud5RbTB2wKuGnQhJt8wkrkqvHVfUWTK7dSEJ4z79RdQMSxEgS2P5SrhqFi3CeRnD26yE FTy8Td2sa2Yp8IDKncEkD9PFWp2paK58xugg+JZbmDr3xfkM0XOma/t5JTjMj01I2ONC 5BmvpcKw0szeK2NTCTK5igkvd6ocmavr0nfouZm9vwfje4PApo+1m2iw/Zs04+QSzXpH Rwhw== X-Gm-Message-State: AOAM531ADJa7cuYw/U5CISV7RI/nGdCET3II4rbgFgHMfHJaE0h2HH0A mXtr8UMPNJMe+qnW+UHsH+HZ6W+acs68elncWcDDbw== X-Google-Smtp-Source: ABdhPJxykPw0xbaH+SS8On5xptBVk0H2ZQ2fCavTGAjGrjgc8Y1611tlzp5Koo7EZOJu+NY5ILUnK7VH/Mhh4l6KVaY= X-Received: by 2002:a1f:1904:: with SMTP id 4mr21787603vkz.9.1635903185278; Tue, 02 Nov 2021 18:33:05 -0700 (PDT) MIME-Version: 1.0 References: <20211026002344.405160-1-sjg@chromium.org> <20211026002344.405160-7-sjg@chromium.org> <20211102165718.GR24579@bill-the-cat> In-Reply-To: <20211102165718.GR24579@bill-the-cat> From: Simon Glass Date: Tue, 2 Nov 2021 19:32:54 -0600 Message-ID: Subject: Re: [PATCH v5 06/26] arm: qemu: Add a devicetree file for qemu_arm64 To: Tom Rini Cc: =?UTF-8?Q?Fran=C3=A7ois_Ozog?= , Albert Aribaud , Heinrich Schuchardt , Ilias Apalodimas , Mark Kettenis , Peter Maydell , QEMU Developers , Sean Anderson , Tuomas Tynkkynen , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Tue, 2 Nov 2021 at 10:57, Tom Rini wrote: > > On Tue, Nov 02, 2021 at 08:59:45AM -0600, Simon Glass wrote: > > Hi Fran=C3=A7ois, > > > > On Mon, 1 Nov 2021 at 11:33, Fran=C3=A7ois Ozog wrote: > > > > > > Hi Simon > > > > > > Le lun. 1 nov. 2021 =C3=A0 17:58, Simon Glass a = =C3=A9crit : > > >> > > >> Hi Peter, > > >> > > >> On Mon, 1 Nov 2021 at 04:48, Peter Maydell wrote: > > >> > > > >> > On Tue, 26 Oct 2021 at 01:33, Simon Glass wrote= : > > >> > > > > >> > > Add this file, generated from qemu, so there is a reference devi= cetree > > >> > > in the U-Boot tree. > > >> > > > > >> > > Signed-off-by: Simon Glass > > >> > > > >> > Note that the dtb you get from QEMU is only guaranteed to work if: > > >> > 1) you run it on the exact same QEMU version you generated it wit= h > > >> > 2) you pass QEMU the exact same command line arguments you used > > >> > when you generated it > > >> > > >> Yes, I certainly understand that. In general this is not safe, but i= n > > >> practice it works well enough for development and CI. > > > > > > You recognize that you hijack a product directory with development ha= ck facility. There is a test directory to keep things clear. There can be a= dev-dts or something similar for Dev time tools. > > > I have only seen push back on those fake dts files in the dts directo= ry: I guess that unless someone strongly favors a continuation of the discu= ssion, you may consider re-shaping the proposal to address concerns. > > > > As stated previously, I would like to have at least a sample DT > > in-tree for all boards. I cannot see another way to get the Kconfig > > What's the point of having a sample when it's not going to always be > correct or may be actively wrong and we can tell interested developers / > users how to get the correct DTB/DTS to examine? > > > options in line. If we are able to put these files somewhere else in > > the future and get them out of U-Boot, with perhaps just an overlay > > for development purposes, I'd be keen to see it. But for now, this is > > where we are, I believe. > > > > In this particular case, this is not just a dev hack. It is also for > > CI tests which need to use a devicetree. See for example here: > > > > https://patchwork.ozlabs.org/project/uboot/patch/20211101011734.1614781= -15-sjg@chromium.org/ > > https://patchwork.ozlabs.org/project/uboot/patch/20211101011734.1614781= -24-sjg@chromium.org/ > > This example would probably be better done on vexpress_ca9x4 where we do > test in CI via QEMU but do not need to modify a device tree that is > passed on to us, we already control the source of truth DTB in this > case. But that board: - uses OF_EMBED, which it should not - does not use SPL, which I need > > And also yes, I'm behind on reviewing things I need to review. Aren't we all...I can't even keep up with these threads. Regards, Simon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD88AC433EF for ; Wed, 3 Nov 2021 01:34:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FF79604DC for ; Wed, 3 Nov 2021 01:34:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6FF79604DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:34436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mi5Ab-0005nV-Ii for qemu-devel@archiver.kernel.org; Tue, 02 Nov 2021 21:34:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mi59I-000571-DY for qemu-devel@nongnu.org; Tue, 02 Nov 2021 21:33:08 -0400 Received: from mail-vk1-xa31.google.com ([2607:f8b0:4864:20::a31]:43806) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mi59G-0000on-MU for qemu-devel@nongnu.org; Tue, 02 Nov 2021 21:33:08 -0400 Received: by mail-vk1-xa31.google.com with SMTP id h133so543472vke.10 for ; Tue, 02 Nov 2021 18:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vTIut1ymaDabKkqB12mW1+gOwQtugPp4jFZ8ypIxeAs=; b=NjqHxqgrxFsZ0bsh2dnhaItxtifP9aRWI/v5WRQ10YASsasvPWQwPqvaL72TPOQAvK a6Tpenu/eI09r6zipxqhk6IN93iuU5Qgy8iUtzZIT6hS+mCUhoVzEnHXCLqhwU1qL8pF jf6e1Ot/5vr/spLOL6wbjl3Poe+knDXN2EiiE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vTIut1ymaDabKkqB12mW1+gOwQtugPp4jFZ8ypIxeAs=; b=BdnT4fsuJ7C9vxtIwse0PXUv/WFeLbX+KDLUHVzUrgLOGUImrLBzPEazISDe0Iou4O raGJhUMJv3wSNF3gTa02bBHJ9lUmE4FFP5hWX8V9cImQofnbPEEllMiks/sYFNukMn08 l2gF1SbcZmMXBu9alUpYGM5qAIRn/7nErAVexzuIstoFB+XJEGEjC/s+W41mcEiBOeeR ZmlapHv/2IKzy+T4LSokqARDRvnd75wApuMOqlOOGIXDGYNkYbYI54nWEZZqsvNbkg1V b+8vRYaL1xIM6zRFSuFV8Kg3fion3Nd0pX7rm+oyjQT/V2QV5n3BiY9aocTddslbEPvh RIxA== X-Gm-Message-State: AOAM533Phb9G5kqdV4a3f7WMnDtbhDOw9n3T/2RmAFjfqmp78XaTV3qO zfFdrbtLlE0SV8cW0LrGQSK8UWJM6HrcqjSgkxgvcQ== X-Google-Smtp-Source: ABdhPJxykPw0xbaH+SS8On5xptBVk0H2ZQ2fCavTGAjGrjgc8Y1611tlzp5Koo7EZOJu+NY5ILUnK7VH/Mhh4l6KVaY= X-Received: by 2002:a1f:1904:: with SMTP id 4mr21787603vkz.9.1635903185278; Tue, 02 Nov 2021 18:33:05 -0700 (PDT) MIME-Version: 1.0 References: <20211026002344.405160-1-sjg@chromium.org> <20211026002344.405160-7-sjg@chromium.org> <20211102165718.GR24579@bill-the-cat> In-Reply-To: <20211102165718.GR24579@bill-the-cat> From: Simon Glass Date: Tue, 2 Nov 2021 19:32:54 -0600 Message-ID: Subject: Re: [PATCH v5 06/26] arm: qemu: Add a devicetree file for qemu_arm64 To: Tom Rini Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::a31; envelope-from=sjg@google.com; helo=mail-vk1-xa31.google.com X-Spam_score_int: -99 X-Spam_score: -10.0 X-Spam_bar: ---------- X-Spam_report: (-10.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.702, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Albert Aribaud , =?UTF-8?Q?Fran=C3=A7ois_Ozog?= , U-Boot Mailing List , Heinrich Schuchardt , Ilias Apalodimas , QEMU Developers , Sean Anderson , Tuomas Tynkkynen , Mark Kettenis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Tom, On Tue, 2 Nov 2021 at 10:57, Tom Rini wrote: > > On Tue, Nov 02, 2021 at 08:59:45AM -0600, Simon Glass wrote: > > Hi Fran=C3=A7ois, > > > > On Mon, 1 Nov 2021 at 11:33, Fran=C3=A7ois Ozog wrote: > > > > > > Hi Simon > > > > > > Le lun. 1 nov. 2021 =C3=A0 17:58, Simon Glass a = =C3=A9crit : > > >> > > >> Hi Peter, > > >> > > >> On Mon, 1 Nov 2021 at 04:48, Peter Maydell wrote: > > >> > > > >> > On Tue, 26 Oct 2021 at 01:33, Simon Glass wrote= : > > >> > > > > >> > > Add this file, generated from qemu, so there is a reference devi= cetree > > >> > > in the U-Boot tree. > > >> > > > > >> > > Signed-off-by: Simon Glass > > >> > > > >> > Note that the dtb you get from QEMU is only guaranteed to work if: > > >> > 1) you run it on the exact same QEMU version you generated it wit= h > > >> > 2) you pass QEMU the exact same command line arguments you used > > >> > when you generated it > > >> > > >> Yes, I certainly understand that. In general this is not safe, but i= n > > >> practice it works well enough for development and CI. > > > > > > You recognize that you hijack a product directory with development ha= ck facility. There is a test directory to keep things clear. There can be a= dev-dts or something similar for Dev time tools. > > > I have only seen push back on those fake dts files in the dts directo= ry: I guess that unless someone strongly favors a continuation of the discu= ssion, you may consider re-shaping the proposal to address concerns. > > > > As stated previously, I would like to have at least a sample DT > > in-tree for all boards. I cannot see another way to get the Kconfig > > What's the point of having a sample when it's not going to always be > correct or may be actively wrong and we can tell interested developers / > users how to get the correct DTB/DTS to examine? > > > options in line. If we are able to put these files somewhere else in > > the future and get them out of U-Boot, with perhaps just an overlay > > for development purposes, I'd be keen to see it. But for now, this is > > where we are, I believe. > > > > In this particular case, this is not just a dev hack. It is also for > > CI tests which need to use a devicetree. See for example here: > > > > https://patchwork.ozlabs.org/project/uboot/patch/20211101011734.1614781= -15-sjg@chromium.org/ > > https://patchwork.ozlabs.org/project/uboot/patch/20211101011734.1614781= -24-sjg@chromium.org/ > > This example would probably be better done on vexpress_ca9x4 where we do > test in CI via QEMU but do not need to modify a device tree that is > passed on to us, we already control the source of truth DTB in this > case. But that board: - uses OF_EMBED, which it should not - does not use SPL, which I need > > And also yes, I'm behind on reviewing things I need to review. Aren't we all...I can't even keep up with these threads. Regards, Simon