From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Tue, 26 Mar 2013 15:14:27 -0700 Subject: [U-Boot] [PATCH 2/8] patman: Don't look for tags inside quotes In-Reply-To: References: <1363833781-14557-1-git-send-email-sjg@chromium.org> <1363833781-14557-3-git-send-email-sjg@chromium.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Doug, On Thu, Mar 21, 2013 at 9:50 AM, Doug Anderson wrote: > Simon, > > On Wed, Mar 20, 2013 at 7:42 PM, Simon Glass wrote: >> # Separates a tag: at the beginning of the subject from the rest of it >> -re_subject_tag = re.compile('([^:]*):\s*(.*)') >> +re_subject_tag = re.compile('([^:"]*):\s*(.*)') > > I'd go further and prevent all spaces. > re_subject_tag = re.compile('([^:\s]*):\s*(.*)') > > I ran into a similar problem with my patch I sent up earlier: > > patman: Add Cover-letter-cc: tag to Cc cover letter to people > > I "fixed" that by removing the extra colon, but that was sorta lame. > We shouldn't have tags with spaces in them anyway... > > patman: Add Cover-letter-cc tag to Cc cover letter to people Yes - will update this, thanks. Regards, Simon