From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Sun, 13 Aug 2017 15:35:47 -0600
Subject: [U-Boot] [U-Boot, v4,
 60/66] rockchip: Kconfig: preset TPL_LDSCRIPT via Kconfig for the
 RK3368
In-Reply-To: <CAK7LNASmFZ93zUAPG0mOx0kJPYwO_x=i3u5qbONNRM8jurk32Q@mail.gmail.com>
References: <1501706105-7490-61-git-send-email-philipp.tomsich@theobroma-systems.com>
 <E1dePC6-0006Xq-Fs@mail.theobroma-systems.com>
 <d9dfdd81-d941-f464-da51-c1b884084aa2@rock-chips.com>
 <4270BB75-844F-422A-990C-F56409F1CBA4@theobroma-systems.com>
 <3a834ddb-20b3-d513-e806-0798efba11fe@rock-chips.com>
 <50813074-4E79-4D65-8504-6C9DC5FDFCFA@theobroma-systems.com>
 <20170807140528.GE29197@bill-the-cat>
 <CAK7LNASmFZ93zUAPG0mOx0kJPYwO_x=i3u5qbONNRM8jurk32Q@mail.gmail.com>
Message-ID: <CAPnjgZ1LJ=sidgE=THZ30TRNaA+aczjrLg8LFOBmQWUSj1hgOA@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: u-boot@lists.denx.de

+Philipp

On 9 August 2017 at 15:45, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> Hi.
>
>
> 2017-08-07 23:05 GMT+09:00 Tom Rini <trini@konsulko.com>:
>> On Mon, Aug 07, 2017 at 10:48:12AM +0200, Dr. Philipp Tomsich wrote:
>>> +Tom
>>>
>>> Ok, so the problem is 'scripts/setlocalversion’, which does the following:
>>> > if test -e include/config/auto.conf; then
>>> >         . include/config/auto.conf
>>> > else
>>> >         echo "Error: kernelrelease not valid - run 'make prepare' to update it"
>>> >         exit 1
>>> > fi
>>> in order to access the variables needed for:
>>> > # CONFIG_LOCALVERSION and LOCALVERSION (if set)
>>> > res="${res}${CONFIG_LOCALVERSION}${LOCALVERSION}"
>>> >
>>> > # scm version string if not at a tagged commit
>>> > if test "$CONFIG_LOCALVERSION_AUTO" = "y"; then
>>> >         # full scm version string
>>> >         res="$res$(scm_version)"
>>> > else
>>> >         # append a plus sign if the repository is not in a clean
>>> >         # annotated or signed tagged state (as git describe only
>>> >         # looks at signed or annotated tags - git tag -a/-s) and
>>> >         # LOCALVERSION= is not specified
>>> >         if test "${LOCALVERSION+set}" != "set"; then
>>> >                 scm=$(scm_version --short)
>>> >                 res="$res${scm:++}"
>>> >         fi
>>> > fi
>>>
>>> So nothing wrong with the changes to Kconfig, but we’re triggering a weakness in our
>>> build infrastructure here.
>>>
>>> I guess we’ll have to implement a save version of scripts/localversion that does not
>>> allow for the execution of arbitrary script code from auto.conf ...
>>
>> Masahiro, do you have any ideas here?  Thanks!
>
>
> I do not like $(ARCH) or $(BOARD) in CONFIG values.
> How hard is it to describe lds paths verbatim?
>
>
>
>
> --
> Best Regards
> Masahiro Yamada
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot