All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [RESEND PATCH v3 5/7] board: Add a gd flag for chain loading
Date: Sun, 26 Apr 2020 13:45:33 -0600	[thread overview]
Message-ID: <CAPnjgZ1LVOPW6wy7iGtKOGv5nv8Qcs0UPcp7xHRMRbxjz6Z4XQ@mail.gmail.com> (raw)
In-Reply-To: <CAEUhbmVQoqWddHvtOZG2A8+PP_Z9aH8KkGrss-Y=scCw-3794A@mail.gmail.com>

Hi Bin,

On Thu, 23 Apr 2020 at 08:00, Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Hi Simon,
>
>
> On Thu, Apr 23, 2020 at 7:03 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > Hi Simon,
> >
> > On Thu, Apr 9, 2020 at 2:58 AM Simon Glass <sjg@chromium.org> wrote:
> > >
> > > When U-Boot is run from another boot loader, much of the low-level init
> > > needs to be skipped.
> > >
> > > Add a flag for this and adjust ll_boot_init() to use it.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > ---
> > >
> > > Changes in v3:
> > > - Add a new patch with a gd flag for chain loading
> > >
> > > Changes in v2: None
> > >
> > >  include/asm-generic/global_data.h | 1 +
> > >  include/init.h                    | 2 +-
> > >  2 files changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_data.h
> > > index 5d027329fe0..3dc51e49ef7 100644
> > > --- a/include/asm-generic/global_data.h
> > > +++ b/include/asm-generic/global_data.h
> > > @@ -166,5 +166,6 @@ typedef struct global_data {
> > >  #define GD_FLG_SPL_EARLY_INIT  0x04000 /* Early SPL init is done          */
> > >  #define GD_FLG_LOG_READY       0x08000 /* Log system is ready for use     */
> > >  #define GD_FLG_WDT_READY       0x10000 /* Watchdog is ready for use       */
> > > +#define GD_FLG_NO_LL_INIT      0x20000 /* Don't perform low-level init    */
> >
> > How about GD_FLG_SKIP_LL_INIT ?
>
> Just noticed that there is an ad-hoc config macro (not converted to
> Kconfig yet) CONFIG_SKIP_LOWLEVEL_INIT.

OK

>
> I suspect we can do some clean up and consolidation here ?

Yes this is quite similar. I agree some clean-up could be done here.
But that option has many build-time effects. I suspect it would be
possible to remove those and do it all at runtime, but it would be a
fair bit of work to do it for all these boards.

[..]

Regards,
Simon

  reply	other threads:[~2020-04-26 19:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08 18:57 [RESEND PATCH v3 0/7] x86: Improve support for chain-loading U-Boot Simon Glass
2020-04-08 18:57 ` [RESEND PATCH v3 1/7] x86: fsp: Allow skipping init code when chain loading Simon Glass
2020-04-08 18:57 ` [RESEND PATCH v3 2/7] x86: apl: Skip " Simon Glass
2020-04-08 18:57 ` [RESEND PATCH v3 3/7] x86: cpu: " Simon Glass
2020-04-08 18:57 ` [RESEND PATCH v3 4/7] pci: Avoid auto-config " Simon Glass
2020-04-08 18:57 ` [RESEND PATCH v3 5/7] board: Add a gd flag for " Simon Glass
2020-04-23 11:03   ` Bin Meng
2020-04-23 14:00     ` Bin Meng
2020-04-26 19:45       ` Simon Glass [this message]
2020-04-08 18:57 ` [RESEND PATCH v3 6/7] x86: Add a way to detect running from coreboot Simon Glass
2020-04-23 11:02   ` Bin Meng
2020-04-08 18:57 ` [RESEND PATCH v3 7/7] x86: Use the existing stack when chain-loading Simon Glass
2020-04-23 11:06 ` [RESEND PATCH v3 0/7] x86: Improve support for chain-loading U-Boot Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ1LVOPW6wy7iGtKOGv5nv8Qcs0UPcp7xHRMRbxjz6Z4XQ@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.