From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0498EB64DA for ; Thu, 20 Jul 2023 19:44:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1CCF8867FE; Thu, 20 Jul 2023 21:43:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="J0ZVYwvb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 10622867FE; Thu, 20 Jul 2023 21:43:12 +0200 (CEST) Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C7BAA8672B for ; Thu, 20 Jul 2023 21:43:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-51e28cac164so4840837a12.1 for ; Thu, 20 Jul 2023 12:43:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689882189; x=1690486989; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=804NsMwgdRPEbQuGtuUKyMHOxnG/UXC9/zfuDEJf8L0=; b=J0ZVYwvbj+JU9Ey+OsV5gZJzviNWuPcSVmcMJ3cswS20WqnkqwKkDLpR0t66tkeWWM s/lV80RbO/SHnwF+Rt55FXptc4vVjlz/91pObK7nlLEth3K3vXYtuj2NLj7ZQmZcpNwT q9gX0dCElgcOPBHVNvz0b334mikSNUQdQW+eg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689882189; x=1690486989; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=804NsMwgdRPEbQuGtuUKyMHOxnG/UXC9/zfuDEJf8L0=; b=OfMu3288rTYtcqX8FkeFkRhNcHc5+FQDEgP8EsRi191xJkev1LF4iIjm8oUjrubLRu 60707QEd4IT9s3NVKfkA7YBWZfPLDM4aEqV7nEaKpFLy0Rj9SDs2YnTn/6nMZRVACasa gWkmYVoUxDNI+eP+pX65w3YFZhTWWRxLsWIDgsvzKnozT9kj++l5nbu55ALh0cmbfwWP tZyms4I5CoYGHvJX98lV9hCZmGmgn71swxFR+wNqeUEPeRrTRJdlCflBXbMRd4DN6gB7 jEK4uRIhxRGyj2SfNylq/eQG+OuM8x9JglFqFAfRdi2eNExRbq16RPZaDvtxapUQx7oX V6Aw== X-Gm-Message-State: ABy/qLZRYxcFo1s+GvRPmcAruXb5ZTkxQbaCUiYtX7FV9tlIKDZ+SOyZ iDMMc1xYeue2qpIa4uwBeTFWwRcSjaLqaG+zIF9ntw== X-Google-Smtp-Source: APBJJlEfNpmsEC+qaCPtjyEF7mKqVaOpaRnDcBlUkLgmqPdvs9JQwucvQui01ThbtVqBqUi7l5uoQGFo3ipNTPzOl4I= X-Received: by 2002:a17:907:9620:b0:982:a022:a540 with SMTP id gb32-20020a170907962000b00982a022a540mr7368611ejc.11.1689882189242; Thu, 20 Jul 2023 12:43:09 -0700 (PDT) MIME-Version: 1.0 References: <20230720112333.9255-1-minda.chen@starfivetech.com> <20230720112333.9255-2-minda.chen@starfivetech.com> In-Reply-To: <20230720112333.9255-2-minda.chen@starfivetech.com> From: Simon Glass Date: Thu, 20 Jul 2023 13:42:55 -0600 Message-ID: Subject: Re: [PATCH v7 1/4] i2c: designware: Add CONFIG_ACPIGEN limitation to designware_i2c_pci.c To: minda.chen@starfivetech.com Cc: Heiko Schocher , Stefan Roese , Andrew Scull , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Mark Kettenis , Rick Chen , Leo , u-boot@lists.denx.de, Mason Huo , Leyfoon Tan , Kevin Xie Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi, On Thu, 20 Jul 2023 at 05:24, Minda Chen wrote: > > As the designware_i2c_pci.c uses ACPI APIs, If some SoCs (StarFive > JH7110) contain designware i2c and PCI but do not use ACPI, > This file will be can't be compiled. So add ACPIGEN to > designware_i2c_pci.c > > Signed-off-by: Minda Chen > --- > drivers/i2c/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile > index 99545df2e5..92b1ec6bc3 100644 > --- a/drivers/i2c/Makefile > +++ b/drivers/i2c/Makefile > @@ -18,9 +18,11 @@ obj-$(CONFIG_SYS_I2C_CADENCE) += i2c-cdns.o > obj-$(CONFIG_SYS_I2C_CA) += i2c-cortina.o > obj-$(CONFIG_SYS_I2C_DAVINCI) += davinci_i2c.o > obj-$(CONFIG_SYS_I2C_DW) += designware_i2c.o > +ifdef CONFIG_ACPIGEN You should use Kconfig to see SYS_I2C_DW depends on ACPIGEN. You might need a separate I2C_DW_PCI Kconfig. But that sounds bad to me. Why does it have to generate ACPI tables? It should work fine without that. > ifdef CONFIG_PCI > obj-$(CONFIG_SYS_I2C_DW) += designware_i2c_pci.o > endif > +endif > obj-$(CONFIG_SYS_I2C_FSL) += fsl_i2c.o > obj-$(CONFIG_SYS_I2C_IHS) += ihs_i2c.o > obj-$(CONFIG_SYS_I2C_INTEL) += intel_i2c.o > -- > 2.17.1 > Regards, Simon