From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spl: spi: Support full fitImage handling
Date: Thu, 7 Jun 2018 12:28:05 -0800 [thread overview]
Message-ID: <CAPnjgZ1MaEt8o42HdE2uJ07o3RBCipV0UDNAhbV_7QERypqvEQ@mail.gmail.com> (raw)
In-Reply-To: <20180531155929.30953-1-marex@denx.de>
Hi Marek,
On 31 May 2018 at 07:59, Marek Vasut <marex@denx.de> wrote:
> Handle the case where the full fitImage support is enabled. In this
> case, the whole fitImage must be loaded up front as some parts of the
> fitImage code require memory-mapped access to the entire fitImage.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
> common/spl/spl_spi.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/common/spl/spl_spi.c b/common/spl/spl_spi.c
> index df46046729..ba60a3a3c5 100644
> --- a/common/spl/spl_spi.c
> +++ b/common/spl/spl_spi.c
> @@ -110,8 +110,17 @@ static int spl_spi_load_image(struct spl_image_info *spl_image,
> return err;
> }
>
> - if (IS_ENABLED(CONFIG_SPL_LOAD_FIT) &&
> - image_get_magic(header) == FDT_MAGIC) {
> + if (IS_ENABLED(CONFIG_SPL_LOAD_FIT_FULL) &&
> + image_get_magic(header) == FDT_MAGIC) {
> + err = spi_flash_read(flash, payload_offs,
> + roundup(fdt_totalsize(header), 4),
> + (void *)CONFIG_SYS_LOAD_ADDR);
map_sysmem(CONFIG_SYS_LOAD_ADDR, fdt_totalsize(header))
otherwise your sandbox test won't work
> + if (err)
> + return err;
> + err = spl_parse_image_header(spl_image,
> + (struct image_header *)CONFIG_SYS_LOAD_ADDR);
Same here
> + } else if (IS_ENABLED(CONFIG_SPL_LOAD_FIT) &&
> + image_get_magic(header) == FDT_MAGIC) {
> struct spl_load_info load;
>
> debug("Found FIT\n");
> --
> 2.16.2
>
Regards,
Simon
next prev parent reply other threads:[~2018-06-07 20:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 15:59 [U-Boot] [PATCH] spl: spi: Support full fitImage handling Marek Vasut
2018-06-07 20:28 ` Simon Glass [this message]
2018-06-07 20:55 ` Marek Vasut
2018-06-07 21:05 ` Simon Glass
2018-07-11 12:41 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ1MaEt8o42HdE2uJ07o3RBCipV0UDNAhbV_7QERypqvEQ@mail.gmail.com \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.