From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32046C433EF for ; Thu, 9 Sep 2021 08:58:06 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A905961139 for ; Thu, 9 Sep 2021 08:58:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A905961139 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 992848320D; Thu, 9 Sep 2021 10:57:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="R9/vUk2i"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 524E58323F; Thu, 9 Sep 2021 10:57:43 +0200 (CEST) Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 49264831BA for ; Thu, 9 Sep 2021 10:57:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-wm1-x32a.google.com with SMTP id y132so794356wmc.1 for ; Thu, 09 Sep 2021 01:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aql7yBnV/3g32p9ybDF78JZcqO1pP2Xos3eV3+pIR+4=; b=R9/vUk2ijDlYIyM4icYhm+wW+RsZn94ZRYMnzceR0HRpePESR4cihVG9DPLmXALng0 Exn1UfyB0gd+ktl28Asl4Hzha2y9bblYT9HdyRGmwpDie2jXzEv5NTKQaV7QelZUk4h6 GKXR9rSmWul1KtVDb9suTcQHStYqmDrhdyyDQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aql7yBnV/3g32p9ybDF78JZcqO1pP2Xos3eV3+pIR+4=; b=xTaUYafpCB/nwlYvTyiJJgxfAepSGCHC9bg64XT07xuLt4qBPNHz5ZYp7iWdrFotzo LoP/GQfWjOi0+1g2SkwK5qCPa3Cu5kIE5bT3RAqOX/77hP9PNaNiqDsRA4BrK7jx8O68 X4/y8bcVyK+G87Jy+mAO/kW5PiOoEygkf7ygFSDsWmuGH2k3R7LvbJrVOxVSEZ0Rr9je 8SKT12KvU/9hY5H6sgqgMx23JcYNCKJfHDCEt1MXy8X+CpKVkrygnKSLqPiZMZd0T6gQ acKMJPaoPAx1Yn1W702ir3yTtKEmmgEjlARemof6qN+nr7NK86VHfSZ8CaAdx7/9RNxd tbHw== X-Gm-Message-State: AOAM531U/WzxtM2yc/cK3XigABQfo5zJJpfdmols7Aahy83k6a/jxUav GyjsPX8cuXcsDQHCusTCJF2zrL91Voa/35KpPXl7Jw== X-Google-Smtp-Source: ABdhPJyu+W6hJMHjrex3uoNfe/DE/cEB5uUYQjEsFCpwtELSpjm0s3WCC8tILZE2J3M5Q4VbmF17IvqMnPqO/3xFu6A= X-Received: by 2002:a7b:cb04:: with SMTP id u4mr1798856wmj.18.1631177852404; Thu, 09 Sep 2021 01:57:32 -0700 (PDT) MIME-Version: 1.0 References: <20210908133405.696481-1-sjg@chromium.org> <20210908073355.2.If4a31ab38420baccea0f0caf799c85966900e784@changeid> In-Reply-To: From: Simon Glass Date: Thu, 9 Sep 2021 02:57:19 -0600 Message-ID: Subject: Re: [PATCH 02/35] x86: Create a new header for EFI To: Heinrich Schuchardt Cc: U-Boot Mailing List , Ilias Apalodimas , Bin Meng , Tom Rini , Christian Melki Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, On Wed, 8 Sept 2021 at 11:27, Heinrich Schuchardt wrote: > > > > On 9/8/21 3:33 PM, Simon Glass wrote: > > The setup routines are called from zimage but don't really belong in the > > zimage header. Add a new EFI header to house these. Add comments so it is > > clear what the functions do. > > > > Signed-off-by: Simon Glass > > --- > > > > arch/x86/include/asm/efi.h | 32 ++++++++++++++++++++++++++++++++ > > arch/x86/include/asm/zimage.h | 3 --- > > arch/x86/lib/zimage.c | 1 + > > 3 files changed, 33 insertions(+), 3 deletions(-) > > create mode 100644 arch/x86/include/asm/efi.h > > In the future we should be able to run the EFI app on any UEFI > architecture. Given this background are the function definitions really > x86 specific? Well firstly that seems like that would be future work for someone. Secondly, this relates to zimage which is really only used by x86 as far as I am aware. Regards, Simon