From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C92EC433EF for ; Tue, 28 Dec 2021 08:42:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4EFE983A93; Tue, 28 Dec 2021 09:37:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Cigb4TsC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 06F2E838AB; Tue, 28 Dec 2021 09:35:30 +0100 (CET) Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C5C6F83917 for ; Tue, 28 Dec 2021 09:35:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-oi1-x22f.google.com with SMTP id u21so15788511oie.10 for ; Tue, 28 Dec 2021 00:35:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M7m0t0y6YCzZx4dzkIgtTi7dKEmk/53a154/dCng018=; b=Cigb4TsCF28Ha0D+tAJozPMHslPtsZTFsfNfkdx8j5InDnbuFUCE4ORvSS5TApASIF eL8P8W0764zowFJro7fVdKdD6IkvUrMav6ClFkNz5zXF6wqv7jhepFXuP7Mz7J2+rg/7 YEzMQczJHwJRSlOcqXR/4oQ7gqrlMEf5nR/9Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M7m0t0y6YCzZx4dzkIgtTi7dKEmk/53a154/dCng018=; b=6H6KyQyLlpBalVx4C2z7DjT6YWILwl+lQtuSrDG+AiYq45Up4YbWlQBCe86PXhafQ3 NU06A9iUbVhlqxXik7QHksOHhBu0OtExemHKSdiJbN6tHx8uNxundUBhCMCY+IU65q6J oJsWwg00yi3mD8AExUz53HnKAF6xPjrFxAxdrrpEntLKwteRlmfk6cPIl39XoSUoBdIZ tm0UgjjPqjzxgsJgQESsaNHlxi7+VVKwzVYDVEzv4Pdl+saqVle2+MK2iRdaQxUEqEqo MlwxiqOCSMGfjBZEFctTkt1jhrqEGTPRk91fWQJQJFlqKOW/xSdSjtEbQQXwnF2Ml8mr KoWA== X-Gm-Message-State: AOAM530Aauhk6DRYDGSVC2fer9bhILu+aYkqGkKR0gGOPSVD67+/At8E NXBZ5h7n5BxUEaAOnO+jNS3LMn16EZgThg46zf45ouSBcp5vrlp4 X-Google-Smtp-Source: ABdhPJxnEYIbyB7dHHtzsAkC3hiR6vKdRo4do+TRMIS1LCvg7DIAl7N7rKacyCnet2fKhQaa/Gafaakxu+M1UUPY6wg= X-Received: by 2002:a05:6808:2289:: with SMTP id bo9mr7487256oib.53.1640680519317; Tue, 28 Dec 2021 00:35:19 -0800 (PST) MIME-Version: 1.0 References: <20211222223607.3734687-1-samuel@dionne-riel.com> <20211222223607.3734687-3-samuel@dionne-riel.com> In-Reply-To: <20211222223607.3734687-3-samuel@dionne-riel.com> From: Simon Glass Date: Tue, 28 Dec 2021 01:34:05 -0700 Message-ID: Subject: Re: [PATCH 2/4] vibrator: Add vibrator_gpio driver To: Samuel Dionne-Riel Cc: U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Samuel, On Wed, 22 Dec 2021 at 15:37, Samuel Dionne-Riel wrote: > > Signed-off-by: Samuel Dionne-Riel > --- > drivers/vibrator/Kconfig | 16 ++++ > drivers/vibrator/Makefile | 1 + > drivers/vibrator/vibrator_gpio.c | 122 +++++++++++++++++++++++++++++++ > 3 files changed, 139 insertions(+) > create mode 100644 drivers/vibrator/vibrator_gpio.c > Reviewed-by: Simon Glass This is fine...but I suggest in future code it might be a good idea to use log_msg_ret() when returning errors. This helps people figure out where they came from. Regards, Simon