From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Mon, 8 Oct 2018 21:40:45 -0600 Subject: [U-Boot] [PATCH 2/2] pci: Change the first CFG read to Vendor ID in enumeration In-Reply-To: References: <20181008083548.44471-1-Zhiqiang.Hou@nxp.com> <20181008083548.44471-2-Zhiqiang.Hou@nxp.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Bin, On 8 October 2018 at 02:54, Bin Meng wrote: > On Mon, Oct 8, 2018 at 4:36 PM Zhiqiang Hou wrote: >> >> From: Hou Zhiqiang >> >> As the PCIe specification recommend reading the Vendor ID register >> to determine if a Function is present, read the Vendor ID of a >> non-existent Function must not result in system error, so we'd better >> make the first CFG read to Vendor ID instead of Header Type register >> in the PCIe enumeration. >> >> Signed-off-by: Hou Zhiqiang >> --- >> drivers/pci/pci.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> > > Simon, do we need fix the non-DM version or adding new "capability" to > the non-DM drivers? I guess the answer is no and we should set some > deadline for PCI DM conversion too? We should not fix or add new features to non-DM PCI. No one should be using it at this point. I agree about the deadline. Do you want to send a patch? Regards, Simon