From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Wed, 12 May 2021 10:01:17 -0600
Subject: [PATCH 1/1] sandbox: ensure that state->ram_buf is in low memory
In-Reply-To: <20210511190316.29710-1-xypron.glpk@gmx.de>
References: <20210511190316.29710-1-xypron.glpk@gmx.de>
Message-ID: <CAPnjgZ1RfPGAw7-XHWnuonSCijuvJKH643MEs9SqEzeapoJF8A@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Heinrich,

On Tue, 11 May 2021 at 13:03, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> Addresses in state->ram_buf must be in the low 4 GiB of the address space.
> Otherwise we cannot correctly fill SMBIOS tables. This shows up in warnings
> like:
>
>     WARNING: SMBIOS table_address overflow 7f752735e020

This sounds like a bug in the smbios-table code. For sandbox it should
perhaps use addresses instead of pointers.

I think that code (that I unfortunately wrote) was an expeditious way
of getting it running, but is not correct.

>
> Ensure that state->ram_buf is initialized by the first invocation of
> os_malloc().
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  arch/sandbox/cpu/start.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>

Regards,
Simon