All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] rockchip: use 'arch-rockchip' as header file path【请注意,邮件由sjg@google.com代发】
Date: Thu, 4 Apr 2019 20:33:49 -0600	[thread overview]
Message-ID: <CAPnjgZ1TXm-KKRF_D1PujnYxGn3t6T8WZUCb8d29cTz6Ach6gw@mail.gmail.com> (raw)
In-Reply-To: <e0c0a598-9073-98a9-9462-00bac219854a@rock-chips.com>

Hi Kever,

On Thu, 4 Apr 2019 at 07:11, Kever Yang <kever.yang@rock-chips.com> wrote:
>
> Hi Simon,
>
>
> On 04/04/2019 03:57 AM, Simon Glass wrote:
> > Hi Kever,
> >
> > On Sat, 30 Mar 2019 at 15:18, Simon Glass <sjg@chromium.org> wrote:
> >> Hi Kever,
> >>
> >> On Wed, 27 Mar 2019 at 21:01, Kever Yang <kever.yang@rock-chips.com> wrote:
> >>> Rockchip use 'arch-rockchip' instead of arch-$(SOC) as common
> >>> header file path, so that we can get the correct path directly.
> >> Can you give a few more details on the reason for this change? I
> >> cannot see the benefit?
> > OK I figured it out from the context.
> >
> > Do you have interest in supporting multiple SoCs with a single build?
>
> Is there other vendor support multiple SoCs?
> For Rockchip platform, I don't think it's easy to do it now, the different
> for different SoCs now:
> - SoC init, eg. debug uart init, sgrf setting and other one time init
> setting;
> - clock driver;
> - pinctrl driver, David still working on it, but the target is for
> minimum size for
>   each SoC, but not enable common code in pinctrl-core as much as possible,
>   so this is the opposite way with support multiple SoCs support.
>
> I would like to use common board/spl/tpl files first, and then step to
> step to
> see what we need to do.

OK. We can today support multiple clock and pinctrl drivers.
Minimising code size is a separate issue to actually making it work.

For SoC init we can use compatible strings to select the init - as you
say, moving to common SPL/TPL is a useful step, but in fact this is
not necessary for use to use a common U-Boot proper. I believe the
main requirement is to create a new config with additional drivers,
then make SPL select the correct DT.

But my concern is that your series to move things to #include asm/arch
precludes supporting more than one SoC. So if we want this, we should
leave things as they are.

If you like I could create a proof of concept for this for two chosen SoCs?

Regards,
Simon

  reply	other threads:[~2019-04-05  2:33 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-28  3:01 [U-Boot] [PATCH 0/3] rockchip: correct SYS_SOC name for all rockchip SoCs Kever Yang
2019-03-28  3:01 ` [U-Boot] [PATCH 1/3] rockchip: arm: use 'arch-rockchip' for common header Kever Yang
2019-03-28  7:02   ` Philipp Tomsich
2019-04-01  7:12   ` Neil Armstrong
2019-04-01 13:13     ` Tom Rini
2019-04-02  0:58       ` Kever Yang
2019-05-01 13:06   ` Philipp Tomsich
2019-03-28  3:01 ` [U-Boot] [PATCH 2/3] rockchip: use 'arch-rockchip' as header file path Kever Yang
2019-03-30 21:18   ` Simon Glass
2019-04-01  1:02     ` [U-Boot] [PATCH 2/3] rockchip: use 'arch-rockchip' as header file path【请注意,邮件由sjg@google.com代发】 Kever Yang
2019-04-01  2:00       ` Simon Glass
2019-04-01  2:46         ` Kever Yang
2019-04-01 19:00           ` Simon Glass
2019-04-02  1:11             ` Kever Yang
2019-04-05  2:33               ` Simon Glass
2019-04-03 19:57     ` [U-Boot] [PATCH 2/3] rockchip: use 'arch-rockchip' as header file path Simon Glass
2019-04-04 13:11       ` [U-Boot] [PATCH 2/3] rockchip: use 'arch-rockchip' as header file path【请注意,邮件由sjg@google.com代发】 Kever Yang
2019-04-05  2:33         ` Simon Glass [this message]
2019-04-28 23:34   ` [U-Boot] [PATCH 2/3] rockchip: use 'arch-rockchip' as header file path Philipp Tomsich
2019-05-01 13:06   ` Philipp Tomsich
2019-03-28  3:01 ` [U-Boot] [PATCH 3/3] rockchip: correct ARCH_SOC name Kever Yang
2019-03-28  7:02   ` Philipp Tomsich
2019-03-28  9:31     ` Kever Yang
2019-05-01 13:06   ` Philipp Tomsich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ1TXm-KKRF_D1PujnYxGn3t6T8WZUCb8d29cTz6Ach6gw@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.