From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D15EBC433EF for ; Thu, 10 Feb 2022 21:01:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EB6928321B; Thu, 10 Feb 2022 22:01:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="PDqjKWw7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D3B8183510; Thu, 10 Feb 2022 22:01:36 +0100 (CET) Received: from mail-ua1-x935.google.com (mail-ua1-x935.google.com [IPv6:2607:f8b0:4864:20::935]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 94DD081A03 for ; Thu, 10 Feb 2022 22:01:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x935.google.com with SMTP id g15so3646237uap.11 for ; Thu, 10 Feb 2022 13:01:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8u5adkEO2XxSgnMH1IUQRh2XBf++tkdEVoxXJ+X8pxY=; b=PDqjKWw7v6O4nKKn8SHQnqrpx++BZPeV0KOlSRbWbRxI0qre6aadoBFX508aKTLkVZ FlMYf/Vv9hNRjoSHUzIOMDNxa+OlEXcycN5pAmKZXk17VRunVo7YEOsnAFsQGysPuZri pkvc7B+37Zs6FQrYzLZoFwyzCYED8SmnyJBVA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8u5adkEO2XxSgnMH1IUQRh2XBf++tkdEVoxXJ+X8pxY=; b=tA7VRSYV8ag1drGKNwBOiVUO9Uvl+kpXqeZO5LgsYJFsZ9IUWGOqx1AgZDcJRdJ1zk Vc7HFmjRHgQisml7Tp+lFxuf58NnsHl+wWI+Y3OT/vy6GAJzcqwslhVHBKdw8V8/d/nB THro6HJ6JsbM+XBoVHozxANJQUrWISn1PUVS5LEgtSUnBuSvO07X0SRk8/2UoPddYukV HlJtfdd8OVVVazELfa4zJS5fM2RDEschVxgGBxpoWojguHB2u5hwXTC/WjBUOyp0wSYh r3NiXh/NEt/vjSpyJxtrgq5idvxuKPM3JWz54EayZrmDjX2uUPW63DlWn6Zif9rTdBws 4JuA== X-Gm-Message-State: AOAM5339+l8U+ewVEq+pzgB7dtLbx3SB5A6pVH4kf+jDic31GCjrHa/0 vFGGUZy65xdLoxgg/zvlXuq47Oaye1RoFIIBAso2nq3E0aE= X-Google-Smtp-Source: ABdhPJxgN1cO8GyKoWH9ngke/zdubyDOYWXi+SnOu/82pLJArVRYAPbIxX4mNGqs+Ourfuqn58tI7v/xENEf7lJYOss= X-Received: by 2002:a05:6130:31d:: with SMTP id ay29mr3505550uab.140.1644526892000; Thu, 10 Feb 2022 13:01:32 -0800 (PST) MIME-Version: 1.0 References: <20220210200824.GI2697206@bill-the-cat> <20220210204051.GJ2697206@bill-the-cat> In-Reply-To: <20220210204051.GJ2697206@bill-the-cat> From: Simon Glass Date: Thu, 10 Feb 2022 14:01:21 -0700 Message-ID: Subject: Re: Please pull u-boot-dm (take 3) To: Tom Rini Cc: U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Thu, 10 Feb 2022 at 13:40, Tom Rini wrote: > > On Thu, Feb 10, 2022 at 01:23:36PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 10 Feb 2022 at 13:08, Tom Rini wrote: > > > > > > On Wed, Feb 09, 2022 at 12:52:02PM -0700, Simon Glass wrote: > > > > > > > Hi Tom, > > > > > > > > This just drops off the final patch of 'take 2' since that is being reworked. > > > > > > > > > > > > running here: > > > > > > > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10936 > > > > > > > > > > > > The following changes since commit 859703251251d9567f29ab10c0a29f98eb0aff5c: > > > > > > > > Merge branch '2022-02-08-Kconfig-updates' (2022-02-09 09:29:07 -0500) > > > > > > > > are available in the Git repository at: > > > > > > > > git://git.denx.de/u-boot-dm.git tags/dm-pull-8feb22-take3 > > > > > > > > for you to fetch changes up to f3078d4ea707931c2307a623ecf6e4d215b413d5: > > > > > > > > binman: Convert FIT entry type to a subclass of Section entry type > > > > (2022-02-09 12:30:13 -0700) > > > > > > > > > > So first, applied to u-boot/master. But I still had to re-generate > > > scripts/pylint.base, and some numbers went down, but the code is > > > cleaner. Can we just make pylint fail when there's serious errors with > > > the code perhaps? > > > > Do you mean fail when the numbers go down? > > No, it fails today when the numbers go down, like this PR did. Or would > have if I didn't just ignore it and accept the lower number because the > code was cleaned up. I mean is there some way to get pylint to say > "this code has serious violations" and non-zero exit rather than just > assign the code a numeric grade? pylint is one of the world's slowest programs. We run in parallel on each file to keep the run time bearable. The return code for individual pylint processes is generally non-zero, unless we happen to get a score of 10. We could use --fail-under but that seems to fail often enough even if the score is exactly equal to the value provided (i.e. we need to subtract 0.01). We could add pylint checking to gitlab and 'make check' since it does at least provide a list of files which have got worse. As to 'serious violations', there are already a lot. There is a flag to only consider certain classes of violations, but for now we cannot turn that on. Perhaps that should be a first step? Regards, Simon