All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/6] binman: Put compressed data into separate files
Date: Wed, 21 Jul 2021 19:12:01 -0700	[thread overview]
Message-ID: <CAPnjgZ1VE5qMz7JfqTe8+k1OsVq2LTote9wbFfCemTOT2sWT=g@mail.gmail.com> (raw)
In-Reply-To: <20210706163641.2280401-2-sjg@chromium.org>

At present compression uses the same temporary file for all invocations.
With multithreading this causes the data to become corrupted. Use a
different filename each time.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 tools/patman/tools.py | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Applied to u-boot-dm, thanks!

      parent reply	other threads:[~2021-07-22  2:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 16:36 [PATCH 0/6] binman: Support compressing files in parallel Simon Glass
2021-07-06 16:36 ` [PATCH 1/6] binman: Put compressed data into separate files Simon Glass
2021-07-06 16:36 ` [PATCH 2/6] binman: Support multithreading for building images Simon Glass
2021-07-06 16:36 ` [PATCH 3/6] binman: Split node-reading out from constructor in files Simon Glass
2021-07-06 16:36 ` [PATCH 4/6] binman: Use bytearray instead of string Simon Glass
2021-07-06 16:36 ` [PATCH 5/6] patman: " Simon Glass
2021-07-06 16:36 ` [PATCH 6/6] binman: Add basic support for debugging performance Simon Glass
2021-07-22  2:11 ` Simon Glass
2021-07-22  2:11 ` [PATCH 5/6] patman: Use bytearray instead of string Simon Glass
2021-07-22  2:11 ` [PATCH 4/6] binman: " Simon Glass
2021-07-22  2:11 ` [PATCH 3/6] binman: Split node-reading out from constructor in files Simon Glass
2021-07-22  2:12 ` [PATCH 2/6] binman: Support multithreading for building images Simon Glass
2021-07-22  2:12 ` Simon Glass [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ1VE5qMz7JfqTe8+k1OsVq2LTote9wbFfCemTOT2sWT=g@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.