All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>,
	Simon Glass <sjg@chromium.org>,
	xypron.glpk@gmx.de,  agraf@csgraf.de,
	ilias.apalodimas@linaro.org, masami.hiramatsu@linaro.org,
	 u-boot@lists.denx.de
Subject: Re: [RFC v2 11/20] dm: add event notification
Date: Sun, 19 Dec 2021 15:17:21 -0700	[thread overview]
Message-ID: <CAPnjgZ1VHKLRE1dDVnAopJ9XTk+J=hr-jMpC6a5K+Bb0U5TMcw@mail.gmail.com> (raw)
In-Reply-To: <20211214070745.GC49357@laputa>

Hi Takahiro,

On Tue, 14 Dec 2021 at 00:07, AKASHI Takahiro
<takahiro.akashi@linaro.org> wrote:
>
> On Mon, Dec 13, 2021 at 05:51:46AM -0700, Simon Glass wrote:
> > Hi Takahiro,
> >
> > On Fri, 10 Dec 2021 at 00:00, AKASHI Takahiro
> > <takahiro.akashi@linaro.org> wrote:
> > >
> > > From: Simon Glass <sjg@chromium.org>
> > >
> > > This is a draft implementation of event notification mechanism from Simon.
> > > Under this scheme, any U-Boot subsystem can register some kind of callback
> > > function to a particular event (more event types will be added later) and
> > > that function will be invoked once the event is fired.
> > >
> > > As a first user, UEFI subsystem makes use of PROBE and REMOVE events so
> > > that we will be able to automatically create/remove efi_disk objects
> > > relying on associated block devices (UCLASS_BLK).
> > >
> > > To run the test:
> > > ./u-boot -T -c "ut common test_event_probe"
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > [add REMOVE event; fix checkpatch warnings]
> > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > > ---
> > >  common/Kconfig                    |  11 ++++
> > >  common/Makefile                   |   2 +
> > >  common/board_f.c                  |   2 +
> > >  common/event.c                    | 103 +++++++++++++++++++++++++++++
> > >  common/log.c                      |   1 +
> > >  drivers/core/device-remove.c      |   9 +++
> > >  drivers/core/device.c             |   9 +++
> > >  include/asm-generic/global_data.h |   3 +
> > >  include/dm/device-internal.h      |  10 +++
> > >  include/event.h                   | 105 ++++++++++++++++++++++++++++++
> > >  include/event_internal.h          |  34 ++++++++++
> > >  include/log.h                     |   2 +
> > >  test/common/Makefile              |   1 +
> > >  test/common/event.c               |  87 +++++++++++++++++++++++++
> > >  test/test-main.c                  |   5 ++
> > >  15 files changed, 384 insertions(+)
> > >  create mode 100644 common/event.c
> > >  create mode 100644 include/event.h
> > >  create mode 100644 include/event_internal.h
> > >  create mode 100644 test/common/event.c
> >
> > Should we split this into a few patches for submission? Also needs docs.
>
> I assumed that you were going to maintain this specific patch.

Ah yes, good point :-)

I will give it a crack.

Regards,
Simon

  reply	other threads:[~2021-12-19 22:17 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10  6:49 [RFC v2 00/20] efi_loader: more tightly integrate UEFI disks to driver model AKASHI Takahiro
2021-12-10  6:49 ` [RFC v2 01/20] part: call part_init() in blk_get_device_by_str() only for MMC AKASHI Takahiro
2021-12-10  6:49 ` [RFC v2 02/20] blk: add a helper function, blk_probe_or_unbind() AKASHI Takahiro
2021-12-13 12:51   ` Simon Glass
2021-12-14  7:01     ` AKASHI Takahiro
2021-12-18 10:55       ` Heinrich Schuchardt
2021-12-20  5:19         ` AKASHI Takahiro
2021-12-10  6:49 ` [RFC v2 03/20] scsi: call device_probe() after scanning AKASHI Takahiro
2021-12-10  6:49 ` [RFC v2 04/20] usb: storage: " AKASHI Takahiro
2021-12-10  6:49 ` [RFC v2 05/20] mmc: " AKASHI Takahiro
2021-12-18  9:48   ` Heinrich Schuchardt
2021-12-18 10:03     ` Heinrich Schuchardt
2022-01-02  9:47   ` Heinrich Schuchardt
2022-01-03 10:09   ` Jaehoon Chung
2021-12-10  6:49 ` [RFC v2 06/20] nvme: " AKASHI Takahiro
2021-12-10  6:49 ` [RFC v2 07/20] sata: " AKASHI Takahiro
2021-12-13 12:51   ` Simon Glass
2021-12-10  6:49 ` [RFC v2 08/20] block: ide: " AKASHI Takahiro
2021-12-10  6:49 ` [RFC v2 09/20] dm: fix an 'undefined' error in some macros AKASHI Takahiro
2021-12-13 12:51   ` Simon Glass
2022-01-07 12:38     ` Ilias Apalodimas
2021-12-10  6:49 ` [RFC v2 10/20] virtio: call device_probe() in scanning AKASHI Takahiro
2021-12-13 12:51   ` Simon Glass
2021-12-10  6:49 ` [RFC v2 11/20] dm: add event notification AKASHI Takahiro
2021-12-13 12:51   ` Simon Glass
2021-12-14  7:07     ` AKASHI Takahiro
2021-12-19 22:17       ` Simon Glass [this message]
2022-01-02  9:41   ` Heinrich Schuchardt
2021-12-10  6:49 ` [RFC v2 12/20] dm: add tag support AKASHI Takahiro
2021-12-13 12:51   ` Simon Glass
2021-12-14  7:05     ` AKASHI Takahiro
2021-12-28  8:32       ` Simon Glass
2021-12-10  6:49 ` [RFC v2 13/20] dm: disk: add UCLASS_PARTITION AKASHI Takahiro
2021-12-10  6:49 ` [RFC v2 14/20] dm: blk: add a device-probe hook for scanning disk partitions AKASHI Takahiro
2021-12-13 12:51   ` Simon Glass
2021-12-10  6:49 ` [RFC v2 15/20] efi_loader: disk: a helper function to create efi_disk objects from udevice AKASHI Takahiro
2022-01-02  9:18   ` Heinrich Schuchardt
2022-01-06  7:16     ` AKASHI Takahiro
2021-12-10  6:49 ` [RFC v2 16/20] efi_loader: disk: a helper function to delete efi_disk objects AKASHI Takahiro
2021-12-10  6:49 ` [RFC v2 17/20] dm: disk: add read/write interfaces with udevice AKASHI Takahiro
2021-12-10  6:49 ` [RFC v2 18/20] efi_loader: disk: use udevice instead of blk_desc AKASHI Takahiro
2021-12-13 12:51   ` Simon Glass
2021-12-10  6:49 ` [RFC v2 19/20] efi_loader: disk: not create BLK device for BLK(IF_TYPE_EFI) devices AKASHI Takahiro
2021-12-13 12:51   ` Simon Glass
2022-01-02  9:19   ` Heinrich Schuchardt
2022-01-06  6:59     ` AKASHI Takahiro
2021-12-10  6:49 ` [RFC v2 20/20] efi_driver: align with efi_disk-dm integration AKASHI Takahiro
2021-12-13 12:51   ` Simon Glass
2022-01-27 15:05 ` [RFC v2 00/20] efi_loader: more tightly integrate UEFI disks to driver model Simon Glass
2022-01-28  5:01   ` AKASHI Takahiro
2022-01-28 12:32     ` AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ1VHKLRE1dDVnAopJ9XTk+J=hr-jMpC6a5K+Bb0U5TMcw@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=agraf@csgraf.de \
    --cc=ilias.apalodimas@linaro.org \
    --cc=masami.hiramatsu@linaro.org \
    --cc=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.