From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Wed, 19 Feb 2020 20:05:03 -0700 Subject: [RFC PATCH 2/2] video: meson: Use reserving memory function without kernel linear mapping In-Reply-To: <20200219184342.15974-3-michael@amarulasolutions.com> References: <20200219184342.15974-1-michael@amarulasolutions.com> <20200219184342.15974-3-michael@amarulasolutions.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Michael, On Wed, 19 Feb 2020 at 11:43, Michael Trimarchi wrote: > > Memory reserved for the simple framebuffer should not be used > and part of memory linear mapping > > Signed-off-by: Michael Trimarchi > --- > drivers/video/meson/meson_vpu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Is there a binding file for this? Please add it to a patch. > > diff --git a/drivers/video/meson/meson_vpu.c b/drivers/video/meson/meson_vpu.c > index 4eb66398d0..134e011b82 100644 > --- a/drivers/video/meson/meson_vpu.c > +++ b/drivers/video/meson/meson_vpu.c > @@ -173,9 +173,9 @@ static void meson_vpu_setup_simplefb(void *fdt) > * at the end of the RAM and we strip this portion from the kernel > * allowed region > */ > - mem_start = gd->bd->bi_dram[0].start; > - mem_size = gd->bd->bi_dram[0].size - meson_fb.fb_size; > - ret = fdt_fixup_memory_banks(fdt, &mem_start, &mem_size, 1); > + mem_start = meson_fb.base; > + mem_size = meson_fb.fb_size; > + ret = fdt_fixup_reserved_memory(blob, "display_reserved", &mem_start, &mem_size); Odd that this uses underscore...normally bindings use hyphen. > if (ret) { > eprintf("Cannot setup simplefb: Error reserving memory\n"); > return; > -- > 2.17.1 > Regards, Simon