All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH v2 0/6] log: Allow multiple lines and conversion to printf()
Date: Thu, 4 Feb 2021 18:20:02 -0700	[thread overview]
Message-ID: <CAPnjgZ1WYZCCUiH5Vi-4+Y7N3qT1UJdM=4rNrU6qHny5ewOinA@mail.gmail.com> (raw)
In-Reply-To: <20210121031057.559301-1-sjg@chromium.org>

+Heinrich Schuchardt

Hi Heinrich,

On Wed, 20 Jan 2021 at 20:11, Simon Glass <sjg@chromium.org> wrote:
>
> At present when logging is not enabled, all log() calls become nops. This
> does not seem right, since if the log level is high enough then there
> should be some sort of message. So in that case, this series updates it to
> print the message if the log level is above LOGL_INFO.
>
> This mimics the behaviour for the log_...() macros like log_debug() and
> log_info(), so we can drop the special case for these.
>
> Also the current implementation does not support multiple log calls on the
> same line nicely. The tags are repeated so the line is very hard to read.
> This series adds that as a new feature.
>
> Changes in v2:
> - Move the newline check into log_dispatch()
> - Update commit message and cover letter to mention log_...() macros
> - Add a test for !CONFIG_LOG
> - Update log() to (effectively) call debug() for log_level == LOGL_DEBUG
>
> Simon Glass (6):
>   log: Set up a flag byte for log records
>   log: Handle line continuation
>   log: Add return-checking macros for 0 being success
>   sandbox: log: Avoid build error with !CONFIG_LOG
>   tpm: Don't select LOG
>   log: Convert log values to printf() if not enabled

I should have sent this series to you as well, since you had a comment
on the original version.

It is at u-boot-dm/log-working if that is easier.

Regards,
Simon

      parent reply	other threads:[~2021-02-05  1:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21  3:10 [PATCH v2 0/6] log: Allow multiple lines and conversion to printf() Simon Glass
2021-01-21  3:10 ` [PATCH v2 1/6] log: Set up a flag byte for log records Simon Glass
2021-03-15 15:52   ` Tom Rini
2021-01-21  3:10 ` [PATCH v2 2/6] log: Handle line continuation Simon Glass
2021-03-15 15:52   ` Tom Rini
2021-01-21  3:10 ` [PATCH v2 3/6] log: Add return-checking macros for 0 being success Simon Glass
2021-03-15 15:52   ` Tom Rini
2021-01-21  3:10 ` [PATCH v2 4/6] sandbox: log: Avoid build error with !CONFIG_LOG Simon Glass
2021-01-21  3:10 ` [PATCH v2 5/6] tpm: Don't select LOG Simon Glass
2021-03-15 15:52   ` Tom Rini
2021-01-21  3:10 ` [PATCH v2 6/6] log: Convert log values to printf() if not enabled Simon Glass
2021-02-05  1:28   ` Sean Anderson
2021-02-05  3:31     ` Simon Glass
2021-03-14 19:33   ` Tom Rini
2021-03-14 20:32     ` Simon Glass
2021-02-05  1:20 ` Simon Glass [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ1WYZCCUiH5Vi-4+Y7N3qT1UJdM=4rNrU6qHny5ewOinA@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.