From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Glass <sjg@chromium.org>
Date: Thu, 26 Nov 2015 18:51:58 -0800
Subject: [U-Boot] [PATCH] common: mmc: unsigned char compared against 0
In-Reply-To: <1448442981-14127-2-git-send-email-Peng.Fan@freescale.com>
References: <1448442981-14127-1-git-send-email-Peng.Fan@freescale.com>
 <1448442981-14127-2-git-send-email-Peng.Fan@freescale.com>
Message-ID: <CAPnjgZ1YqAv3Vf-OAR1WzoP6OZmx8W984UQDSBryigY_g0yxyw@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Peng,

On 25 November 2015 at 01:16, Peng Fan <Peng.Fan@freescale.com> wrote:
> "enable" is unsigned char type and its value will not be
> negative, so discard "enable < 0".
>
> Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
> Cc: Diego Santa Cruz <Diego.SantaCruz@spinetix.com>
> Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> Cc: Andrew Gabbasov <andrew_gabbasov@mentor.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> ---
>  common/cmd_mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Even better if this variable changed to uint, instead of u8.

Regards,
Simon