From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD636C433F5 for ; Thu, 14 Oct 2021 20:44:16 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2616C61167 for ; Thu, 14 Oct 2021 20:44:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2616C61167 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2D9B78368D; Thu, 14 Oct 2021 22:44:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="EK3ftur8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CF74683658; Thu, 14 Oct 2021 22:43:57 +0200 (CEST) Received: from mail-ua1-x935.google.com (mail-ua1-x935.google.com [IPv6:2607:f8b0:4864:20::935]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9E53683658 for ; Thu, 14 Oct 2021 22:43:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@google.com Received: by mail-ua1-x935.google.com with SMTP id r22so3084937uat.11 for ; Thu, 14 Oct 2021 13:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CEivAqYEc9qKdOEV5uIHWuWuV0h2BGKeUSIDFxVG0/Q=; b=EK3ftur8/LNJLTqMHt7o6sUGYBdNw9/GmlSa3FVdxcETjXMRT9RnfZq3Tdq/IkSE7k 4kv8Z32gptxuxOCINjSW/jVOENqoQnBJp2WJOA9jYG+cMLjtHfDHh4oBEK/XBAjsX0/H X3XbNkYREnGvaU1aKpZydBLQheZkyMpy9DRvg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CEivAqYEc9qKdOEV5uIHWuWuV0h2BGKeUSIDFxVG0/Q=; b=TNemRwyIDIJX6vReFKK5lNMSm7wk2UDBCQ92r9MatCN7ZtGdfrmRjbfxyj4QdzsgvN R38sK0hUq4XbPi2mbgGkwbRwUVoHYovrLYAUO13teNoOUlDWvsdpvR/WPP92HC2ChVWa psZJ3tN6jFfKZWB/jDT6PfzHybAK9BfrubGqs0aTUj1MiMvSSNEg8gTmhOIaQmzYMHg9 8E4aKNC8U2HIDpcukyjVvfsld+hyXApWSakUs4+F3orhc37VJ+4NbfzO6cHeGqdgoiOi +tGX6JXpsOCPk9KaCspobqjdSIkGFHKYEXjr4WRXcyNqkaxKjgtLkjX4nIYpAjFJNIFX qUpg== X-Gm-Message-State: AOAM530jPI+RkcX6d22/7WKJTI6YclYg40AxfYHLswE69fbHgPjbCgtf n3ANZ0+Kh8kCPkRvrF8FzKvby6zrO+pStzZ/yzFPwQ== X-Google-Smtp-Source: ABdhPJwpQZ+wAN7NNUosW7qbU5vHwGC4WeBQVtg4Enf58x7Q6l6IIGL22mzkMWEC8fMTdzuIiVbThC+IGWCAQKFh/Ic= X-Received: by 2002:a05:6102:3577:: with SMTP id bh23mr9948889vsb.8.1634244232217; Thu, 14 Oct 2021 13:43:52 -0700 (PDT) MIME-Version: 1.0 References: <20211003183050.67925-1-kettenis@openbsd.org> <20211003183050.67925-3-kettenis@openbsd.org> In-Reply-To: From: Simon Glass Date: Thu, 14 Oct 2021 14:43:41 -0600 Message-ID: Subject: Re: [PATCH v2 2/7] test: Add tests for IOMMU uclass To: Mark Kettenis Cc: Mark Kettenis , U-Boot Mailing List , Bin Meng , Nicolas Saenz Julienne Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Mark, On Thu, 14 Oct 2021 at 13:51, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Mon, 11 Oct 2021 11:00:36 -0600 > > > > On Sun, 3 Oct 2021 at 12:31, Mark Kettenis wrote: > > > > > > Add a set of tests for the IOMMU uclass. > > > > > > Signed-off-by: Mark Kettenis > > > --- > > > arch/sandbox/dts/test.dts | 6 ++++++ > > > configs/sandbox64_defconfig | 1 + > > > configs/sandbox_defconfig | 1 + > > > configs/sandbox_flattree_defconfig | 1 + > > > configs/sandbox_noinst_defconfig | 1 + > > > configs/sandbox_spl_defconfig | 1 + > > > drivers/iommu/Makefile | 2 ++ > > > drivers/iommu/sandbox_iommu.c | 18 ++++++++++++++++++ > > > test/dm/Makefile | 1 + > > > test/dm/iommu.c | 28 ++++++++++++++++++++++++++++ > > > 10 files changed, 60 insertions(+) > > > create mode 100644 drivers/iommu/sandbox_iommu.c > > > create mode 100644 test/dm/iommu.c > > > > > > > Reviewed-by: Simon Glass > > > > You could add the CONFIG options to sandbox's Kconfig in arch/Kconfig > > The codebase is a bit inconsistent in that respect isn't it? Do you mean sometimes it is in defconfig and sometimes in Kconfig? Yes. For the sandbox board, we try to enable everything For the other boards that use the sandbox arch, we have to enable what is needed to run tests, but not necessarily every feature Regards, Simon