All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/7] net: Remove the Faraday ftgmac100 controller driver
Date: Tue, 9 Oct 2018 10:19:12 -0600	[thread overview]
Message-ID: <CAPnjgZ1_LgdJSTzXUHyxMNGL0qPMJXYYNnfPNqZoVzZvxM-uAw@mail.gmail.com> (raw)
In-Reply-To: <97f527ea-5600-2cfc-80fc-0f4e5c9f312c@kaod.org>

Hi Cedric,

On 2 October 2018 at 09:48, Cédric Le Goater <clg@kaod.org> wrote:
> On 10/2/18 1:22 PM, Simon Glass wrote:
>> On 1 October 2018 at 01:53, Cédric Le Goater <clg@kaod.org> wrote:
>>> There are too many changes in the following patch fixing support for
>>> the Faraday ftgmac100 controller. To ease the review, remove the whole
>>> file which is not compiled anymore today (no Kconfig option for the
>>> driver).
>>>
>>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>>> ---
>>>  drivers/net/ftgmac100.h | 242 -----------------
>>>  include/netdev.h        |   1 -
>>>  drivers/net/ftgmac100.c | 582 ----------------------------------------
>>>  drivers/net/Makefile    |   1 -
>>>  4 files changed, 826 deletions(-)
>>>  delete mode 100644 drivers/net/ftgmac100.h
>>>  delete mode 100644 drivers/net/ftgmac100.c
>>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>
>> Assuming Joe is happy to remove this and start again? While it is
>> easier to review, it does remove commit history which is bad.
>
> yes.
>
> The changes are so numerous that it is really difficult to understand
> what the resulting driver looks like and splitting the changes would
> have been nightmarish. So I took the short path as the driver was not
> compiled anymore, but this is questionable.
>
> I can also resend without the initial removal patch but wouldn't it
> invalidate the review at the same time ?

Yes but it is not hard to re-review in this case.

Regards,
Simon

  reply	other threads:[~2018-10-09 16:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-01  8:53 [U-Boot] [PATCH v2 0/7] Support for the Faraday ftgmac100 controller Cédric Le Goater
2018-10-01  8:53 ` [U-Boot] [PATCH v2 1/7] net: Remove the Faraday ftgmac100 controller driver Cédric Le Goater
2018-10-02 11:22   ` Simon Glass
2018-10-02 15:48     ` Cédric Le Goater
2018-10-09 16:19       ` Simon Glass [this message]
2018-10-09 20:44         ` Joe Hershberger
2018-10-09 21:09           ` Cédric Le Goater
2018-10-09 21:19             ` Joe Hershberger
2018-10-09 21:34               ` Cédric Le Goater
2018-10-01  8:53 ` [U-Boot] [PATCH v2 2/7] net: Re-add support for the Faraday ftgmac100 controller Cédric Le Goater
2018-10-01  8:53 ` [U-Boot] [PATCH v2 3/7] aspeed: ast2500: fix missing break in D2PLL clock enablement Cédric Le Goater
2018-10-01  8:53 ` [U-Boot] [PATCH v2 4/7] net: ftgmac100: Add support for the Aspeed SoC Cédric Le Goater
2018-10-02 11:22   ` Simon Glass
2018-10-01  8:53 ` [U-Boot] [PATCH v2 5/7] aspeed: Update ast2500 SoC DTS file to Linux v4.17-rc6 level Cédric Le Goater
2018-10-02 11:22   ` Simon Glass
2018-10-01  8:53 ` [U-Boot] [PATCH v2 6/7] aspeed: Activate ethernet devices on the ast2500 Eval Board Cédric Le Goater
2018-10-01  8:53 ` [U-Boot] [PATCH v2 7/7] aspeed: ast2500: fix D2-PLL clock setting in RGMII mode Cédric Le Goater
2018-10-02 11:22   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnjgZ1_LgdJSTzXUHyxMNGL0qPMJXYYNnfPNqZoVzZvxM-uAw@mail.gmail.com \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.